-
Notifications
You must be signed in to change notification settings - Fork 0
Getting started with schedules #305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
1240f2f
to
09eda88
Compare
09eda88
to
63ad237
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks basically good already. I found some smaller issues, though.
- The layout of the empty state notice is broken when becoming narrow. I'd probably opt for a flex box solution.
- I find the timestamps for the scale pretty distracting, especially when the columns width becomes really narrow. We had this offline already and I see the points you made about the locale stuff. But can we probably try to decrease the line-height and fade the AM/PMs?
Something like this.
.timescale .timestamp {
line-height: 1;
}
.timescale .timestamp > span:last-child {
opacity: 0.5;
}
-
Can you adjust the background of the empty-state button container? It's a little too dark. I noticed, that I used a custom value. It's #d9d9d9 in the mockup, but with 25% opacity. Probably @gray-lighter would be close, but also with 25%. I think you can use
fade(@gray-light, 25%)
. -
Same for the "Add another …" Button. And the row header should be the same colors, please.
-
Not sure if it's addressed in a different issue, but the row header should be the same as the body row area, when highlighted.
63ad237
to
b920a05
Compare
9f54900
to
5d70ce3
Compare
da504df
to
d29b2ef
Compare
44650de
to
3934a9a
Compare
5d70ce3
to
8664a42
Compare
3934a9a
to
8ebf977
Compare
8664a42
to
2d26ce3
Compare
8ebf977
to
1843a0c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "Add another rotation" version looks great.
In the empty state version, the content is not centered, though.
2d26ce3
to
90c1773
Compare
1843a0c
to
c8f3dc0
Compare
90c1773
to
66111dc
Compare
c8f3dc0
to
c147701
Compare
66111dc
to
6762542
Compare
8502278
to
81d245c
Compare
81d245c
to
1efb1b9
Compare
6762542
to
0e30729
Compare
The base branch was changed.
a2a5a93
to
8d5a961
Compare
- Add `empty-notice` and `Add Rotation` button under `.day-header` - Hide clock
- Add button to the .overlay element - Overlap sidebar entry (.placeholder) with the button row
- Remove float for `cog` icon
8d5a961
to
5093797
Compare
resolves #280
Blocked By:
#292