Skip to content

Revert "Ensure new/updated rows having a changed_at greater than all previous ones" #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Al2Klimov
Copy link
Member

This reverts commit 5ddc751.

As you requested, now completely different channels won't conflict (40001) w/ each other, as they don't SELECT a common MAX(changed_at) in a serializable tx.

But one and the same e.g channel would still conflict (40001) if updated by two users which is good.

@Al2Klimov Al2Klimov requested a review from nilmerg April 24, 2025 10:07
@cla-bot cla-bot bot added the cla/signed CLA is signed by all contributors of a PR label Apr 24, 2025
@Al2Klimov
Copy link
Member Author

@julianbrost @oxzi @nilmerg But, honestly speaking, as I already said:

Web is a point&click thing, so generally the users are slow enough not to run into #311 (40001 error), ex. once or twice a year.

It is simply the right thing that a row, which is committed later, has a greater changed_at than previous ones. Especially if our incremental config update mechanism relies on it!

@julianbrost
Copy link
Collaborator

I'm missing context to understand what you're doing here.

@Al2Klimov
Copy link
Member Author

The point is, our incremental config update mechanism relies on strongly sequential changed_at not to miss any updates. I ensured this consistency with this:

And now @nilmerg says, like, Oh no! Now, whenever two user edit distinct channels during the same(!) very few ms [which happens.. once a year? twice.. ? Who cares?], one of them gets an error message [saying that tx serialization failed or similar] and has to re-submit. This is bad!

The Go daemon's incremental config update mechanism regularily selects only config updates newer than the last known one.
@Al2Klimov Al2Klimov removed their assignment Apr 25, 2025
@Al2Klimov Al2Klimov marked this pull request as ready for review April 25, 2025 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla/signed CLA is signed by all contributors of a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants