Merge pull request #10417 from Icinga/inverted-hacluster-check

Fix inverted `IsHACluster` check

Author: julianbrost

lib/remote/apilistener.cpp

@@ -1927,11 +1927,7 @@ void ApiListener::ValidateTlsHandshakeTimeout(const Lazy<double>& lvalue, const
 bool ApiListener::IsHACluster()
 {
 	Zone::Ptr zone = Zone::GetLocalZone();
-
-	if (!zone)
-		return false;
-
-	return zone->IsSingleInstance();
+	return zone && zone->IsHACluster();
 }
 
 /* Provide a helper function for zone origin name. */

lib/remote/zone.cpp

@@ -125,10 +125,10 @@ bool Zone::IsGlobal() const
 	return GetGlobal();
 }
 
-bool Zone::IsSingleInstance() const
+bool Zone::IsHACluster() const
 {
-	Array::Ptr endpoints = GetEndpointsRaw();
-	return !endpoints || endpoints->GetLength() < 2;
+	auto endpoints = GetEndpointsRaw();
+	return endpoints && endpoints->GetLength() >= 2;
 }
 
 Zone::Ptr Zone::GetLocalZone()

lib/remote/zone.hpp

@@ -29,7 +29,7 @@ class Zone final : public ObjectImpl<Zone>
 	bool CanAccessObject(const ConfigObject::Ptr& object);
 	bool IsChildOf(const Zone::Ptr& zone);
 	bool IsGlobal() const;
-	bool IsSingleInstance() const;
+	bool IsHACluster() const;
 
 	static Zone::Ptr GetLocalZone();