Skip to content

Icinga DB: cancel_time in downtime history should not be 0 #9612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
julianbrost opened this issue Dec 14, 2022 · 3 comments · May be fixed by #10379
Open

Icinga DB: cancel_time in downtime history should not be 0 #9612

julianbrost opened this issue Dec 14, 2022 · 3 comments · May be fixed by #10379
Assignees
@yhabteab
Labels
area/icingadb New backend

Comments

@julianbrost
Copy link
Contributor

The following sends a 0 value for cancel_time in the downtime history if the downtime wasn't actually cancelled:
https://github.com/Icinga/icinga2/blob/master/lib/icingadb/icingadb-objects.cpp#L1923

This will then write a 0 timestamp to the corresponding column in the database rather than a NULL value. Icinga 2 should either write null to Redis or omit the key in the JSON altogether if the downtime wasn't cancelled.

refs Icinga/icingadb-web#691
@julianbrost julianbrost added the area/icingadb New backend label Dec 14, 2022
@yhabteab yhabteab self-assigned this Jan 24, 2023
@Al2Klimov
Copy link
Member

@yhabteab Are you actually working on this?

@yhabteab yhabteab removed their assignment May 4, 2023
@yhabteab
Copy link
Member

yhabteab commented May 4, 2023

@yhabteab Are you actually working on this?

Nope!

@Al2Klimov
Copy link
Member

There is a workaround in place at the moment so it’s NOT a production issue:

@yhabteab yhabteab self-assigned this Mar 14, 2025
@yhabteab yhabteab linked a pull request Mar 14, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yhabteab yhabteab

Labels
area/icingadb New backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

IcingaDB: Sync downtime cancel_time conditionally Icinga/icinga2
3 participants
@julianbrost @Al2Klimov @yhabteab