Address golangci-lint issues #1026
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initialize a .golangci.yml configuration file based on the configuration file from Icinga Notifications[0]. [0]: https://github.com/Icinga/icinga-notifications/blob/272ecf231f59f94a5bf56739ab11263f0c69a081/.golangci.yml
There were multiple occurrences of forcetypeassert throughout the codebase. In most cases, an if guard was added to return an error. Sometimes, a panic was raised as refactoring would be too much. And once, a nolint annotation was added as the actual check was out of scope.
The linter cannot handle icingadb-migrate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address golangci-lint issues which are not shown in pull requests as within PRs, only new issues are hinted. After this change, we are clean on linter issues.
Details are available in the commit messages.