Open
Conversation
PHP enforces method signature compatibility when traits are combined in a class hierarchy. Because `EventEmitterTrait` declares `on()` without a return type, any subclass that inherits `on()` from a base using `Events` and also uses `EventEmitterTrait` triggers a fatal error at load time due to the conflicting `: static` annotation. Dropping the return type makes `Events` composable alongside `EventEmitterTrait` in shared class hierarchies.
lippserd
force-pushed
the
evenement-compat
branch
from
6926001 to
0072d77
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP enforces method signature compatibility when traits are combined in a
class hierarchy. Because
EventEmitterTraitdeclareson()without areturn type, any subclass that inherits
on()from a base usingEventsand also uses
EventEmitterTraittriggers a fatal error at load time dueto the conflicting
: staticannotation.Dropping the return type makes
Eventscomposable alongsideEventEmitterTraitin shared class hierarchies.