fix(vhelper): fix padding only when vhelper scrollbar is visible (#15972)

Author: didimmova

projects/igniteui-angular/src/lib/core/styles/components/drop-down/_drop-down-theme.scss

@@ -259,7 +259,7 @@
         -webkit-overflow-scrolling: touch;
         position: relative;
 
-        igx-display-container {
+        .igx-display-container--scrollbar {
             padding-inline-end: var(--vhelper-scrollbar-size);
         }
     }

projects/igniteui-angular/src/lib/directives/for-of/base.helper.component.ts

@@ -7,11 +7,14 @@ import {
     AfterViewInit,
     Inject,
     NgZone,
-    DOCUMENT
+    Renderer2,
+    PLATFORM_ID,
+    inject
 } from '@angular/core';
 import { Subject } from 'rxjs';
 import { takeUntil, throttleTime } from 'rxjs/operators';
 import { resizeObservable, PlatformUtil } from '../../core/utils';
+import { DOCUMENT, isPlatformBrowser } from '@angular/common';
 
 @Directive({
     selector: '[igxVirtualHelperBase]',
@@ -27,13 +30,16 @@ export class VirtualHelperBaseDirective implements OnDestroy, AfterViewInit {
     private _afterViewInit = false;
     private _scrollNativeSize: number;
     private _detached = false;
+    protected renderer = inject(Renderer2);
+    protected platformId = inject(PLATFORM_ID);
+    protected ngZone = inject(NgZone);
 
     constructor(
         public elementRef: ElementRef<HTMLElement>,
         public cdr: ChangeDetectorRef,
         protected _zone: NgZone,
         @Inject(DOCUMENT) public document: any,
-        protected platformUtil: PlatformUtil,
+        protected platformUtil: PlatformUtil
     ) {
         this._scrollNativeSize = this.calculateScrollNativeSize();
     }
@@ -104,6 +110,34 @@ export class VirtualHelperBaseDirective implements OnDestroy, AfterViewInit {
         return this.document.body.contains(this.nativeElement);
     }
 
+    private toggleClass(element: HTMLElement, className: string, shouldHaveClass: boolean): void {
+        if (shouldHaveClass) {
+            this.renderer.addClass(element, className);
+        } else {
+            this.renderer.removeClass(element, className);
+        }
+    }
+
+    private updateScrollbarClass() {
+        if (!isPlatformBrowser(this.platformId)) {
+            return;
+        }
+
+        this.ngZone.runOutsideAngular(() => {
+            requestAnimationFrame(() => {
+            const el = this.nativeElement;
+            const hasScrollbar = el.scrollHeight > el.clientHeight;
+            const prevSibling = el.previousElementSibling as HTMLElement | null;
+            const scrollbarClass = 'igx-display-container--scrollbar';
+
+            if (prevSibling?.tagName.toLowerCase() === 'igx-display-container') {
+                this.toggleClass(prevSibling, scrollbarClass, hasScrollbar);
+            }
+            });
+        });
+    }
+
+
     protected handleMutations(event) {
         const hasSize = !(event[0].contentRect.height === 0 && event[0].contentRect.width === 0);
         if (!hasSize && !this.isAttachedToDom) {
@@ -113,6 +147,8 @@ export class VirtualHelperBaseDirective implements OnDestroy, AfterViewInit {
             // attached back now.
             this.restoreScroll();
         }
+
+        this.updateScrollbarClass();
     }
 
     protected restoreScroll() {}

projects/igniteui-angular/src/lib/directives/for-of/horizontal.virtual.helper.component.ts

@@ -1,5 +1,6 @@
-import { Component, ElementRef, HostBinding, Input, ViewChild, ViewContainerRef, ChangeDetectorRef, Inject, NgZone, DOCUMENT } from '@angular/core';
+import { Component, ElementRef, HostBinding, Input, ViewChild, ViewContainerRef, ChangeDetectorRef, Inject, NgZone } from '@angular/core';
 import { VirtualHelperBaseDirective } from './base.helper.component';
+import { DOCUMENT } from '@angular/common';
 import { PlatformUtil } from '../../core/utils';
 
 /**
@@ -18,7 +19,13 @@ export class HVirtualHelperComponent extends VirtualHelperBaseDirective {
     @HostBinding('class')
     public cssClasses = 'igx-vhelper--horizontal';
 
-    constructor(elementRef: ElementRef, cdr: ChangeDetectorRef, zone: NgZone, @Inject(DOCUMENT) document, platformUtil: PlatformUtil) {
+    constructor(
+        elementRef: ElementRef,
+        cdr: ChangeDetectorRef,
+        zone: NgZone,
+        @Inject(DOCUMENT) document: any,
+        platformUtil: PlatformUtil
+    ) {
         super(elementRef, cdr, zone, document, platformUtil);
     }
 

projects/igniteui-angular/src/lib/directives/for-of/virtual.helper.component.ts

@@ -1,6 +1,7 @@
 import { Component, ElementRef, HostBinding, Input, ViewChild, ViewContainerRef,
-    ChangeDetectorRef, OnDestroy, OnInit, Inject, NgZone, DOCUMENT } from '@angular/core';
+    ChangeDetectorRef, OnDestroy, OnInit, Inject, NgZone} from '@angular/core';
 import { VirtualHelperBaseDirective } from './base.helper.component';
+import { DOCUMENT } from '@angular/common';
 import { PlatformUtil } from '../../core/utils';
 
 @Component({
@@ -20,7 +21,13 @@ export class VirtualHelperComponent extends VirtualHelperBaseDirective implement
     @HostBinding('class')
     public cssClasses = 'igx-vhelper--vertical';
 
-    constructor(elementRef: ElementRef, cdr: ChangeDetectorRef, zone: NgZone, @Inject(DOCUMENT) document, platformUtil: PlatformUtil) {
+    constructor(
+        elementRef: ElementRef,
+        cdr: ChangeDetectorRef,
+        zone: NgZone,
+        @Inject(DOCUMENT) document: any,
+        platformUtil: PlatformUtil,
+    ) {
         super(elementRef, cdr, zone, document, platformUtil);
     }