-
Notifications
You must be signed in to change notification settings - Fork 156
refactor(*): bundle styles with components #15125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
simeonoff
wants to merge
127
commits into
master
Choose a base branch
from
simeonoff/scoped-styles
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* refactor(grid-summary): remove redundant code and colors * deps(*): update theming version
* refactor(input-group): initial themes structure, Also adding styles for material box(input,textarea,select and combo). * refactor(input-group): adding the rest of the material types styles - Removing the logic for themes inside the .ts file, removing all classes related to specific themes. - Updating the showcase sample - wrapping the label theme in base layer * refactor(input-group): adding styles for indigo - modify the input group template - disabled typography - fix some layout issues - move more styles to base - update wc version and add file type input in the sample * refactor(input-group): initial bootstrap styling * refactor(input-group): finalize input group styling * refactor(input-group): fix showcase sample error * refactor(combo): prepare combo theme * refactor(select): prepare select theme * refactor(input-group): fix some layout issues Add clear icon colors in file type input. * refactor(input-group): finalize the input-group styles also update the showcase sample to add remove the hint * refactor(combo): finalize styles * fix(input-group): use the correct color variable for focus background in indigo theme * fix(input-group): revert the variable until we have an agreement on this * fix(input-group): make sure the the upload button is using its own padding not the prefix/ suffix padding+ * fix(Combo): add display contents to the new wrapper around the combo search and content use it to only scope the variables * fix(input-group): Make sure that the search use the same shadow on focus as it uses on hover * chore(combo): cleanup commented code * fix(input-group): mace sure that the default size is working as before * fix(combo): dont remove the old class and fix the padding for the add container * fix(input-group): remove untalented import from the showcase sample * fix(combo): fix test for combo and simple combo * fix(input-group): fix native input padding in suffixed/prefixed variants * fix(combo): fix case sensitive icon color in fluent theme * fix(combo): fix case sensitive icon color/border in bootstrap theme * fix(combo): fix indigo caret color * fix(input-group): rever back to hardcoded dolor for case-icon (required by the design team)
handle placeholder with css
…ombo clear button parameters (#15966) * fix(grid & combo): remove grid negative margin & fix combo clear button parameters * fix(combo): fix spacing
handle placeholder with css
* feat(combo): fix combo initial dropdown height * refactor(themes): update dropdown theme to use a CSS variable for item count --------- Co-authored-by: Simeon Simeonoff <sim.simeonoff@gmail.com>
- We should not remove a border or any schema-connected style from the theme. Rather, we should update the variable in the schema, which in this case is already done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13770
Additional information (check all that apply):
Checklist:
feature/README.MD
updates for the feature docsREADME.MD
CHANGELOG.MD
updates for newly added functionalityng update
migrations for the breaking changes (migrations guidelines)