Skip to content

Make 'clear selection' button focusable and add keyboard navigation for it #15867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 18, 2025
Merged

Make 'clear selection' button focusable and add keyboard navigation for it #15867

merged 4 commits into from
Jul 18, 2025

Conversation

@MonikaKirkova
Copy link
Contributor

@MonikaKirkova MonikaKirkova commented May 30, 2025 •
edited
Loading

Closes #15841

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@MonikaKirkova MonikaKirkova added ♿ a11y When the issue or PR is related to accessibility combo aria-support simple-combo labels May 30, 2025
@MonikaKirkova MonikaKirkova added the ❌ status: awaiting-test PRs awaiting manual verification label May 30, 2025
@MonikaKirkova MonikaKirkova requested a review from Lipata June 2, 2025 13:43
@kacheshmarova kacheshmarova requested review from ChronosSF and removed request for Lipata July 3, 2025 12:17
ChronosSF
ChronosSF previously approved these changes Jul 11, 2025
View reviewed changes
@ChronosSF ChronosSF self-requested a review July 15, 2025 12:13
@ddaribo ddaribo added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Jul 15, 2025
@ChronosSF ChronosSF merged commit c46b339 into 19.2.x Jul 18, 2025
5 checks passed
@ChronosSF ChronosSF deleted the mkirkova/feat-combo-clear-selection-15841 branch July 18, 2025 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChronosSF ChronosSF ChronosSF approved these changes

Assignees

@ddaribo ddaribo

Labels

aria-support combo simple-combo version: 19.2.x ♿ a11y When the issue or PR is related to accessibility ✅ status: verified Applies to PRs that have passed manual verification

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@MonikaKirkova @ChronosSF @ddaribo @kacheshmarova