fix(vhelper): fix padding only when vhelper scrollbar is visible #15972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
didimmova
added
❌ status: awaiting-test
desig9stein
added
💥 status: in-test
simeonoff
reviewed
Jun 25, 2025
projects/igniteui-angular/src/lib/directives/for-of/base.helper.component.ts
Show resolved
Hide resolved
simeonoff
reviewed
Jun 26, 2025
|
|
||
| private toggleClass(element: HTMLElement, className: string, add: boolean): void { | ||
| if (!element) return; | ||
| add ? this.renderer.addClass(element, className) : this.renderer.removeClass(element, className); |
There was a problem hiding this comment.
Nitpick, but I'd use a regular control flow "if / else" statement here instead of a ternary operator.
simeonoff
reviewed
Jun 26, 2025
Comment on lines
39
to
41
| private renderer: Renderer2, | ||
| @Inject(PLATFORM_ID) private platformId: Object, | ||
| private ngZone: NgZone |
There was a problem hiding this comment.
Try to use the inject API so you don't have to also modify all classes that extend the base class.
simeonoff
approved these changes
Jun 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15965
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)