Skip to content

feat(icon): add aria-hidden="true" attribute by default + test - 20.0.x #16010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: Mass Merging 20.0.x to master
merged 8 commits into from
Aug 20, 2025
Merged

feat(icon): add aria-hidden="true" attribute by default + test - 20.0.x #16010

merged 8 commits into from
Aug 20, 2025

Conversation

@ddaribo
Copy link
Contributor

@ddaribo ddaribo commented Jun 30, 2025

Closes #16008

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@ddaribo ddaribo mentioned this pull request Jun 24, 2025
Closed
4 tasks
@ddaribo ddaribo requested a review from damyanpetev July 3, 2025 06:19
@ddaribo ddaribo mentioned this pull request Jul 4, 2025
Merged
18 tasks
@ddaribo ddaribo mentioned this pull request Jul 30, 2025
Merged
18 tasks
@ddaribo ddaribo changed the title feat(icon): add aria-hidden="true" attribute by default + test feat(icon): add aria-hidden="true" attribute by default + test - 20.0.x Jul 30, 2025
@ddaribo ddaribo linked an issue Jul 30, 2025 that may be closed by this pull request
IgxIcon text is always announced by Assistive technologies #16008
Closed
@rkaraivanov rkaraivanov self-requested a review August 7, 2025 11:57
@ddaribo ddaribo mentioned this pull request Aug 7, 2025
Merged
18 tasks
@ddaribo ddaribo removed the request for review from damyanpetev August 7, 2025 12:58
@IvanKitanov17 IvanKitanov17 added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Aug 8, 2025
@kacheshmarova kacheshmarova merged commit 04c8b53 into 20.0.x Aug 20, 2025
2 of 4 checks passed
@kacheshmarova kacheshmarova deleted the bpachilova/icon-aria-hidden-16008 branch August 20, 2025 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rkaraivanov rkaraivanov rkaraivanov approved these changes

Assignees

@IvanKitanov17 IvanKitanov17

Labels

🖼️ icon version: 20.0.x ✅ status: verified Applies to PRs that have passed manual verification

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

IgxIcon text is always announced by Assistive technologies

4 participants

@ddaribo @rkaraivanov @kacheshmarova @IvanKitanov17