-
Notifications
You must be signed in to change notification settings - Fork 156
Grid Cell merging #16024
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Grid Cell merging #16024
Changes from 103 commits
Commits
Show all changes
112 commits
Select commit
Hold shift + click to select a range
7562cc5
chore(*): Cell merge POC.
f42bb3c
chore(*): Minor tweaks to suggestion.
870e7f6
chore(*): Implement with rows that are retained outside the virt.frame.
bb4e39f
chore(*): Fix border styles.
e160c65
chore(*): Add handling for variable row height.
4667bb0
chore(*): Add handling if different rows have different sizes.
febbd43
chore(*): Extract hardcoded styles in class.
4c5d922
chore(*): Adjust API and members.
a42b192
chore(*): Add mergeStrategy for grid and merging comparer for column.
1361952
chore(*): Adjust pipe triggers.
407357f
chore(*): Re-use cell templates.
f23dd6c
chore(*): Fix row indexes in merged row area.
f6ffa42
chore(*): Adjust some styles for row selection.
4d1b981
chore(*): Merged cells navigation.
aca57ee
chore(*): Adjust for scenarios after horizontal nav into merged cell.
e168c3a
chore(*): Add integration with pinning.
02b866a
chore(*): Merge cells in pinned col.
d515e97
chore(*): Adjust check for non-mergeable record types.
95e5b40
chore(*): Break merge sequence on row activation. Discard custom merg…
759b465
chore(*): Merge in pinned row area.
9329079
chore(*): Implement selection per spec.
19c2efe
chore(*): Add hover styles.
52860e8
chore(*): Fix duplicate host listeners.
16d4ac6
chore(*): Merge ghost(pinned) records with same value in main area.
f81bd27
chore(*): Fix check for merged data.
2ba947e
chore(*): Refactor to calculate mergedData rows only on chunk change.
95d0186
chore(*): Cache merge data index and re-use in template.
2a65bc2
chore(*): Cell merge in hierarchical grid - initial commit.
5c4587f
chore(*): Implement for tree grid. Add 2 strategies.
7ac17e4
chore(*): Export strategies in package.
401370e
chore(*): Fix chip displaying when in merged cell.
5e1b702
chore(*): Minor tweaks. Console warn on invalid setup.
58e6bfa
chore(*): Fix lint errors.
5e81bf9
chore(*): Fix theming lint.
b2b61a7
chore(*): Fix build and imports.
9a7a2d2
chore(*): Add null check.
ce0c854
chore(*): Null check for activeRowIndex.
a6fc511
chore(*): Generate elements config.
d025473
chore(*): Break up merge groups on cell selection.
190f29d
chore(*): Update active indexes on events. Cache result to limit pipe…
50e7d85
chore(*): When searching, mark merged cells as a single result.
1e560e8
chore(*): Refresh search if needed only.
7db787a
chore(*): Fix scrollTo when scrolling to a merged cell that has large…
86bc021
chore(*): Add basic merging tests.
91c457b
chore(*): Add some UI tests for merging.
a5c5566
chore(*): Add some integration tests.
46ea7ae
chore(*): Add more integration tests.
f862469
chore(*): Add more integration tests.
fc46739
chore(*): Add Hgrid and TreeGrid integration tests.
ea9baa6
chore(*): Fix lint i tests.
1f4c554
chore(*): Update Changelog.
94eb0a8
Merge branch 'master' into mkirova/cell-merge-POC-2
cc47820
chore(*): Fix unrelated respy issue in combo tests.
35a1bde
chore(*): Fix hardcoded value in unrelated test.
a7970d1
chore(*): Improve samples a bit.
5ab08a8
chore(*): In case cell is merged cell placeholder, do not render cont…
229bcd1
chore(*): Adjust indexes when there are pinned rows to top.
e64ee01
chore(*): Fix templates in hgrid and tgrid.
238390f
chore(*): Update external merge container on data changing.
c071635
chore(*): Adjust selection check for pinned row root.
9f1ffd0
chore(*): Fix more indexes due to row pinning.
0ae58e0
chore(*): Fix tgrid check.
2267e03
chore(*): Clear active row indexes when selection is cleared.
6178a23
chore(*): Adjust selection check to use pinned view if row is pinned.
d044219
chore(*): Fix scrollbar disappearing on data changing.
b8a77e2
chore(*): Notify changes after merge data is updated.
0351166
chore(*): Apply review comments on styles.
9cc56b6
chore(*): Extract key from tree grid record.
cbf4a1c
chore(*): Update merge indexes when in a paged grid context.
e491681
chore(*): Update size if repaint was requested. Optimize a bit index …
5d2a5ce
chore(*): Remove unnecessary inherit that overrides selection in pin …
db23777
chore(*): Fix timing issue between activation and drag selection.
3f7c27e
chore(*): Make activation and merge tests async.
2bbd9b8
chore(*): Approximate click position in merge cell to activate closes…
bcae71b
chore(*): Pass clientY when simulating pointer events in tests.
c081168
Merge remote-tracking branch 'origin/master' into mkirova/cell-merge-…
ChronosSF 2d6b443
chore(*): Fix background styles when pinned and merged.
2a9726d
Merge branch 'mkirova/cell-merge-POC-2' of https://github.com/IgniteU…
f69b105
chore(*): Fix background styles when merged, hovered and selected.
13b4c24
chore(*): Add merge strategy to pipe trigger so that it can be change…
05e42c6
chore(*): Change detect on runtime strategy change.
e46786e
Merge branch 'master' into mkirova/cell-merge-POC-2
ChronosSF a06132a
fix(*): Fix positioning in pin right scenario. Extract styles in class.
5528867
chore(*): Fix border styles for cell merging.
4f75644
Merge branch 'master' into mkirova/cell-merge-POC-2
ChronosSF 968363c
Merge branch 'master' into mkirova/cell-merge-POC-2
ChronosSF b052b64
Merge pull request #16107 from IgniteUI/mkirova/cell-merge-right-pin-fix
ChronosSF 8e45f72
chore(*): Apply review comments.
MayaKirova d6b9e8e
chore(*): Update tests since border is now removed.
e235e83
Merge branch 'mkirova/cell-merge-POC-2' of https://github.com/IgniteU…
88e01da
Merge branch 'master' into mkirova/cell-merge-POC-2
e91b097
chore(*): Add explicit notifyChange after activeNode is changed.
6e103ac
chore(*): Add merge strategy interface api docs.
75fd965
chore(*): Small review comments.
69b272c
chore(*): Limit how often visibleColumns array changes.
1a4fbd9
chore(*): Cache columnsToMerge and use as pipe trigger.
0483273
chore(*): Remove sortExpr as pipe trigger, since no longer needed.
6d148a4
chore(*): More optimizations for merged cols eval.
a17df96
chore(*): Remove change detect on mergeStrategy change.
a892a57
chore(*): Add handling for different date related dataTypes on column.
a503659
chore(*): Add test for date column.
69ba10d
chore(*): Apply review comments.
638df68
chore(*): Add scroll inertia in merged rows outside of virt.frame.
173532f
chore(*): merging pinning with cell merging
ChronosSF 4d1c477
chore(*): applying modified merge for pinning
ChronosSF 4c7495e
fix(merging): applying a performance improv for merging pipe
ChronosSF f624236
Merge pull request #16176 from IgniteUI/sstoychev/merge-pinning-cellm…
ChronosSF 17dd6c0
Merge remote-tracking branch 'origin/master' into mkirova/cell-merge-…
ChronosSF 514ad96
chore(docs): resolving broken changelog merge
ChronosSF c5507de
Merge branch 'master' into mkirova/cell-merge-POC-2
ChronosSF 7e15c92
chore(docs): removing duplicated changelog entry.
ChronosSF e406dee
Merge branch 'master' into mkirova/cell-merge-POC-2
ChronosSF File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is important needed here and in the consequent placeholder selectors?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's because if the pinned cell style:
It overwrites the background, when the cell is also pinned.