Skip to content

Conversation

IvanKitanov17
Copy link
Contributor

Closes #15810

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@kacheshmarova kacheshmarova requested a review from ddaribo July 23, 2025 07:09
@ddaribo ddaribo added 💥 status: in-test PRs currently being tested version: 20.0.x labels Jul 23, 2025
ddaribo
ddaribo previously approved these changes Jul 24, 2025
@ddaribo ddaribo added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Jul 24, 2025
@RivaIvanova RivaIvanova added 💥 status: in-test PRs currently being tested and removed ✅ status: verified Applies to PRs that have passed manual verification 💥 status: in-test PRs currently being tested labels Jul 24, 2025
@RivaIvanova
Copy link
Member

RivaIvanova commented Jul 24, 2025

@IvanKitanov17
Currently, the hierarchical grid fires selected and rangeSelected on any click (clicking on a templated cell or not). You should add && !event.target.closest('igx-hierarchical-grid-cell') as well. This should resolve the issue with the rangeSelected event being fired, and I will log the behavior of the selected event in a separate issue.
IMO, there should be tests added for the tree grid and hierarchical grid as well, since the current test will pass even if only if (!event.target.closest('igx-grid-cell')) is left.

EDIT: Logged the hGrid selected event issue here.

@RivaIvanova RivaIvanova added the 🛠️ status: in-development Issues and PRs with active development on them label Jul 24, 2025
@RivaIvanova RivaIvanova added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed 🛠️ status: in-development Issues and PRs with active development on them 💥 status: in-test PRs currently being tested labels Jul 25, 2025
@RivaIvanova RivaIvanova requested a review from ddaribo July 25, 2025 08:06
@kacheshmarova kacheshmarova merged commit 185b87c into 20.0.x Jul 25, 2025
5 checks passed
@kacheshmarova kacheshmarova deleted the ikitanov/fix#15810-20.0.x branch July 25, 2025 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

grid: selection version: 20.0.x ✅ status: verified Applies to PRs that have passed manual verification

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants