Skip to content

Conversation

IMinchev64
Copy link
Contributor

@IMinchev64 IMinchev64 commented Oct 20, 2025

Related to #16024

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@ChronosSF ChronosSF requested a review from Copilot October 21, 2025 12:31
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds the missing export for DefaultMergeStrategy in the public API of the igniteui-angular-elements package, addressing issue #16024.

  • Added import of DefaultMergeStrategy from the merge-strategy module
  • Exported DefaultMergeStrategy with the IgcDefaultMergeStrategy alias

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@IMinchev64 IMinchev64 changed the title fix(elements): add export for DefaultMergeStrategy fix(elements): add export for DefaultMergeStrategy - 20.1.x Oct 21, 2025
@MayaKirova MayaKirova added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Oct 21, 2025
@MayaKirova
Copy link
Contributor

@IMinchev64 @dkamburov @skrustev Extending the default merge strategy in react works fine now, however when building from this branch and bundling the packages for react manually it seems that merging breaks:

cell-merge-issue

Not sure if it's an issue with missing styles or maybe something else that caused issue with the size of the merged cells. Either way it needs more investigation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants