SettingWakeUp: use Checkboxlist.h #2123
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build size and comparison to main:
|
Update `CheckboxList.h` to optionally be able to get checkboxes (instead of the default of radio-buttons) and be able to have multi-selection through a new callback. Use these updated capabilities of `CheckboxList.h` to replace the nearly identical code of `SettingWakeUp.h` One noticable change is that previously all 5 wake-up-settings were on the same page. But with this PR and the default value of 4 settings per screen on `CheckboxList.h` we have two pages.
NeroBurner
force-pushed
the
checkboxlist_for_settingWakeUp
branch
from
3bd5277 to
d5e3dff
Compare
|
I like the idea and the implementation via the I am only reading the code right now, but think we can simplify the interface. If I understand it correctly, the function is provided for checkboxes and the original value is provided for radio buttons? Can we infer the style from that and omit the boolean flag? And maybe make the original value optional, if it is not always needed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
CheckboxList.hto optionally be able to get checkboxes (instead of the default of radio-buttons) and be able to have multi-selection through a new callback.Use these updated capabilities of
CheckboxList.hto replace the nearly identical code ofSettingWakeUp.hOne noticable change is that previously all 5 wake-up-settings were on the same page. But with this PR and the default value of 4 settings per screen on
CheckboxList.hwe have two pagesBefore:
Now:
