ci: Normalise slash-containing github.head_ref values
#2166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build size and comparison to main:
|
shymega
force-pushed
the
ci-fix-normalise-head-ref
branch
2 times, most recently
from
47c8d6c to
f0122ac
Compare
|
@mark9064 If you could run the workflow one more time - I was testing in zsh locally, not bash - tested in bash with the recent force-push, and it works locally. Should be fine now. |
|
No worries, CI development is the worst because testing in prod is basically the only way :P |
shymega
force-pushed
the
ci-fix-normalise-head-ref
branch
from
f0122ac to
8ac0c9b
Compare
|
One more time - then if that fails, I'll take a look either before or after working hours today. |
|
I think you might need to escape the forward slash in the substitution. I.e. |
|
On 15.11.2024 06:30, FintasticMan wrote:
I think you might need to escape the forward slash in the substitution. I.e. `${ref_name//\//-}`
The latest push should have the above implemented.
Best wishes,
--
Dom Rodriguez
|
shymega
force-pushed
the
ci-fix-normalise-head-ref
branch
from
8ac0c9b to
e7e4868
Compare
|
Ah, meant to push! Done now. |
shymega
force-pushed
the
ci-fix-normalise-head-ref
branch
from
e7e4868 to
73be6e5
Compare
FintasticMan
requested changes
Nov 15, 2024
This fixes CI on InfiniTimeOrg#2121. Signed-off-by: Dom Rodriguez <shymega@shymega.org.uk>
shymega
force-pushed
the
ci-fix-normalise-head-ref
branch
from
73be6e5 to
f6ab516
Compare
|
Excellent! Once we get this landed, I'll rebase #2121 - and then we can merge that, too! |
JF002
approved these changes
Nov 17, 2024
|
Thanks for your contribution @shymega |
This was referenced Nov 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes CI on #2121.