Skip to content

Conversation

NeroBurner
Copy link
Contributor

@NeroBurner NeroBurner commented May 28, 2025

Same change as done in c3295d6 But for get-base-ref-size job

The variable substitution I introduced in #2299 are bash features. So they don't work with sh.

Update the size job to use bash instead of sh as shell

Same change as done in c3295d6
But for get-base-ref-size job

The variable substitution I introduced are bash features. So they don't work with sh.

Update the size job to use `bash` instead of `sh` as shell
@NeroBurner NeroBurner added this to the 1.16.0 milestone May 28, 2025
@NeroBurner NeroBurner added bug Something isn't working maintenance Background work labels May 28, 2025
Copy link

Build size and comparison to main:

Section Size Difference
text 375844B 0B
data 948B 0B
bss 22536B 0B

Run in InfiniEmu

@NeroBurner NeroBurner requested a review from a team May 28, 2025 11:53
@NeroBurner NeroBurner self-assigned this May 28, 2025
@NeroBurner NeroBurner merged commit 22cb7e3 into main May 29, 2025
5 checks passed
JustScott pushed a commit to JustScott/InfiniTime that referenced this pull request Jul 29, 2025
Same change as done in InfiniTimeOrg@c3295d6
But for get-base-ref-size job

The variable substitution I introduced are bash features. So they don't work with sh.

Update the size job to use `bash` instead of `sh` as shell
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working maintenance Background work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants