Skip to content

Conversation

tituscmd
Copy link
Contributor

@tituscmd tituscmd commented Jun 7, 2025

Hello everybody!

This is another simple PR of mine.
This PR removes the leading before the BPM value in the Heart Rate app. Previously it would say "083", but now it looks like this:
bpm
I think this is cleaner than with the leading zero, but it might be up to preference.

Let me know what you think!

Copy link

github-actions bot commented Jun 7, 2025

Build size and comparison to main:

Section Size Difference
text 379204B 0B
data 944B 0B
bss 22536B 0B

Run in InfiniEmu

@mark9064 mark9064 added the UI/UX User interface/User experience label Jun 7, 2025
@mark9064
Copy link
Member

Should we change the default --- since it's no longer always 3 characters? Or maybe it's a complete non-issue and looks fine in practice, would be interested to hear :)

@tituscmd
Copy link
Contributor Author

Should we change the default --- since it's no longer always 3 characters? Or maybe it's a complete non-issue and looks fine in practice, would be interested to hear :)

imageimage
In my custom version of this UI, I also use two dashes instead of the three. The reason being that, most of the time, your heart rate will likely be double digit.

@minacode
Copy link
Contributor

minacode commented Jul 3, 2025

Or just one? I think, I am fine with any of the variants.

@tituscmd
Copy link
Contributor Author

Or just one? I think, I am fine with any of the variants.

I think two digits "--" would be the most logical approach here, because that's the amount of digits your heart rate is going to be most of the time.
If that makes sense to y'all, I could definitely open another PR to replace every 0 (in the context of heart rate) with "--"

@minacode
Copy link
Contributor

Okay, let's try two and get this merged! 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI/UX User interface/User experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants