Resolve paint corrupting screen scrolling #2324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build size and comparison to main:
|
|
Simulator needs IsScrolling copied over |
NeroBurner
approved these changes
Oct 5, 2025
|
Opened InfiniTimeOrg/InfiniSim#182 I haven't tested infinisim with this at all yet, it definitely fixes on HW (not sure if issue reproduced on sim before either) Edit: If sim CI is green we should retrigger CI here before merging just to check it's all good - I haven't tested the sim build |
|
already in the fixed edit, I clicked on the original wrong link in the EMail notification. Sorry for the noise |
NeroBurner
pushed a commit
to InfiniTimeOrg/InfiniSim
that referenced
this pull request
Oct 8, 2025
|
@NeroBurner CI all green now, OK to merge? |
NeroBurner
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2034
The main problem is calling FlushDisplay while scrolling causes bad behaviour