Music: Redesign Part 2#2337
Conversation
Alarm: Simplify alarm alerting screen (InfiniTimeOrg#2211)
…oach to switching between skipping and volume buttons
|
Build size and comparison to main:
|
Co-authored-by: mark9064 <30447455+mark9064@users.noreply.github.com>
…nto music_redesign_2
…nto music_redesign_2
mark9064
left a comment
mark9064
left a comment
There was a problem hiding this comment.
Pretty much there I think :)
|
One other thing, could you edit the first message to show screenshots of the latest version? Just makes it a bit easier for anyone looking at the PR for the first time |
…g an array for the buttons and labels
|
I made the button labels a bit more gray when the buttons are disabled, so it’s easier to tell at a glance what’s inactive. I updated the first message of this PR as well so it matches the current UI, making it clearer for anyone checking it out for the first time - thanks for pointing that out @mark9064 :D |
|
Had a poke around, few suggestions here (mainly to avoid storing copies of all the buttons/labels again). I think the only substantial code change required is to fix the the progress bar narrowing issue, You can apply the changes locally with |
Totally didn't think of that, good catch. |
|
This looks super cool! |
Thank you so much! 😊 |
|
Could we get this added to 1.17? It's a nice qol update |
|
Added to milestone @tituscmd can you sync with main (merge/rebase)? |
Should be all good to go! |
* music app redesign * removed an empty line * Some tweaks for the default texts, as well as adding a different approach to switching between skipping and volume buttons * formatting * more formatting * revert back to swiping as a gesture to switch between skip and volume buttons * remove all unneccessary references to the motor controller * formatting * removed accidental change * correct color of the buttons * remove redundant initialisers for trackName and albumName * add progress bar * Update settings.json * formatting * formatting * more formatting * different design for music.cpp * renaming to camelCase, time top center, some visual tweaks * tweak code for much easier alignment testing * tweak code for much easier alignment testing * change controls button * tweaks to the new swap controls button * Different version of the music app, where all buttons are on one screen * another UI iteration, my favorite (volume buttons above track buttons) * version with buttons up top * clean up code * finally got a formatting extension, so this is hopefully the last formatting commit * finally got a formatting extension, so this is hopefully the last formatting commit (ironically one more) * some final spacing optimizations * remove some more (now) unused lines * lots of code optimization, mainly to get the reconnection smoother * remove unused emoji * Update Music.cpp Co-authored-by: mark9064 <30447455+mark9064@users.noreply.github.com> * react to review, most notably change artist, track and album to use DirtyValue * use bleState.isUpdated() instead of manual lastConnected approach * change behavior of Refresh cycle * I'll never understand why it does this * remove album as member, remove unused members * remove now unused music disc files * de-clutter the SetDisconnectedUI and SetConnectedUI functions by using an array for the buttons and labels * apply patch from github, thanks mark! * formatting * clamp track duration to bar range to avoid any possible overflow --------- Co-authored-by: tituscmd <154823939+tituscmd@users.noreply.github.com> Co-authored-by: Titus Kendzorra <titus@kendzorra.de> Co-authored-by: mark9064 <30447455+mark9064@users.noreply.github.com>
7 participants
Hey everybody,
Since creating PR #2292 and introducing a small little redesign of the music app, I've had some more time on my hands and finally came around to creating a better version of it.
I've moved the artist and track name up a bit to add a new progress bar that shows the progress of the song you're listening to, with the time that has passed shown on the left and the time remaining shown on the right.
Sadly, I've had to remove (comment out) the disc animation in the top right because of space issues. If anyone is especially fond of the disc I'm sure space can be made to fit it back in. It is definitely not a final decision by me, hence why it's only commented out and not removed altogether.
But now that I've temporarily removed the disc animation, the top of the screen seemed quite empty to me. And after some thinking and digging through the code, I stumbled upon these lines of code in the Music.cpp:
And so I thought "why not do that?" and I added an indicator text at the top telling you if you are connected via bluetooth. Please share your opinion on this.
Finally, here are some pictures of it all:
