Skip to content

Conversation

tituscmd
Copy link
Contributor

Hey everyone!

This is a redesign of the UI for the settings page for validate the firmware.

This is the screen for when the firmware is validated
Screenshot 2025-07-29 at 00-09-20 InfiniEmu

And this is the screen for when the firmware is not yet validated. I changed the text to explain what happens when the firmware isn't validated, rather than just telling you to validate it, so that new users understand what they’re doing :)
Screenshot 2025-07-29 at 00-09-17 InfiniEmu

Tell me what you think!

Copy link

github-actions bot commented Jul 28, 2025

Build size and comparison to main:

Section Size Difference
text 380276B 144B
data 944B 0B
bss 22544B 0B

Run in InfiniEmu

@skarn958
Copy link

skarn958 commented Aug 2, 2025

I really like it. It's clearer and more straight forward.

@mark9064 mark9064 added enhancement Enhancement to an existing app/feature UI/UX User interface/User experience labels Aug 5, 2025
@mark9064
Copy link
Member

mark9064 commented Aug 5, 2025

This is way better :)

The only bit I'm not sure about is the rounded button corners. I feel like the rest of the corners in the OS are a bit more square?

@tituscmd
Copy link
Contributor Author

tituscmd commented Aug 5, 2025

The only bit I'm not sure about is the rounded button corners. I feel like the rest of the corners in the OS are a bit more square?

I originally based that decision on the buttons like in the Steps and Timer screen, but after a second look it seems that most other screens in InfiniTime where there are two buttons next to each other do in fact use more square-looking corner radiuses (or radii if you will ;))

Here's how that would look like:
image
I like that as well and, as far as I'm concerned, we can for sure go with that design rather than the circle corner radius

@mark9064
Copy link
Member

mark9064 commented Aug 5, 2025

Also, just thinking about the text would "Rollback" describe what the button does better? Not sure if the longer label would fit nicely though...

@marigoldfish
Copy link

How about "Revert"?

@tituscmd
Copy link
Contributor Author

tituscmd commented Aug 10, 2025

image

I actually like "Rollback" a lot. Not only does it match with the text above, but the longer label also matches the longer label on the "Validate" button.

If everyone is happy with this I'll push the two commits (the squircle buttons and the label change) and then the PR should be all set from my side :)

@tituscmd
Copy link
Contributor Author

I’ve now pushed those two commits (squircle buttons and label change)

image

I actually like "Rollback" a lot. Not only does it match with the text above, but the longer label also matches the longer label on the "Validate" button.

If everyone is happy with this I'll push the two commits (the squircle buttons and the label change) and then the PR should be all set from my side :)

I’ve now pushed those two commits

@tituscmd
Copy link
Contributor Author

Just a little friendly bump that I've now pushed the last changes and this PR should be ready to merge, if desired :)

@mark9064 mark9064 self-requested a review August 26, 2025 22:57
@tituscmd
Copy link
Contributor Author

Reviewed changes have been pushed 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to an existing app/feature UI/UX User interface/User experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants