update images for Azure SCIM (azure updated UI on their side)#4601
Closed
ashwin-infisical wants to merge 1 commit into
Closed
update images for Azure SCIM (azure updated UI on their side)#4601ashwin-infisical wants to merge 1 commit into
ashwin-infisical wants to merge 1 commit into
Conversation
Customer reported that Azure UI has changed around SCIM. Need to put more recent images to reflect the actual use case.
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Greptile Overview
Summary
This PR addresses a customer-reported issue where Azure's user interface for SCIM (System for Cross-domain Identity Management) configuration has been updated, making the existing documentation images outdated. The change adds inline comments to five image references in the Azure SCIM documentation file (`docs/documentation/platform/scim/azure.mdx`) to mark them for updating.The modifications are purely administrative - each affected image markdown link now has a comment # update with current azure UI images appended to it. The actual image file paths remain unchanged, suggesting this is part of a two-phase process where the comments serve as markers for identifying which images need to be replaced with current Azure UI screenshots.
This change fits into Infisical's broader documentation maintenance strategy, as SCIM integration is a critical enterprise feature that enables automated user provisioning between identity providers like Azure Active Directory and Infisical. Keeping these visual guides current is essential for customer success, as outdated screenshots can cause confusion during the SCIM setup process and potentially lead to configuration errors.
Changed Files
| Filename | Score | Overview |
|---|---|---|
| docs/documentation/platform/scim/azure.mdx | 5/5 | Added inline comments to 5 image references marking them for Azure UI updates |
Confidence score: 5/5
- This PR is safe to merge with minimal risk as it only adds documentation comments without changing functionality
- Score reflects the non-critical nature of the changes - only adding comments to mark images for future updates
- No files require special attention as this is a simple documentation maintenance task
Sequence Diagram
sequenceDiagram
participant Customer
participant Infisical Support
participant Developer
participant Azure UI
participant Documentation
Customer->>Infisical Support: "Reports Azure UI has changed around SCIM"
Infisical Support->>Developer: "Customer feedback: Azure SCIM UI outdated"
Developer->>Azure UI: "Reviews current Azure interface"
Azure UI-->>Developer: "Shows updated UI elements"
Developer->>Documentation: "Updates azure.mdx file"
Note over Documentation: Updates image references with #comments
Documentation-->>Developer: "File modified with new image placeholders"
Developer->>Documentation: "Commits changes to patch-1 branch"
Developer->>Documentation: "Creates PR to merge into main"
Note over Documentation: PR includes updated SCIM configuration steps
1 file reviewed, 1 comment
Comment on lines
+51
to
+67
|  #update with current azure UI images | ||
|
|
||
| After you hit **Save**, select **Provision Microsoft Entra ID Users** under the **Mappings** subsection. | ||
|
|
||
|  | ||
|  #update with current azure UI images | ||
|
|
||
| Next, adjust the mappings so you have them configured as below: | ||
|
|
||
|  | ||
|  #update with current azure UI images | ||
|
|
||
| Finally, head to your Enterprise Application > Provisioning and set the **Provisioning Status** to **On**. | ||
|
|
||
|  | ||
|  #update with current azure UI images | ||
|
|
||
| Alternatively, you can go to **Overview** and press **Start provisioning** to have Azure start provisioning/deprovisioning users to Infisical. | ||
|
|
||
|  | ||
|  #update with current azure UI images |
Contributor
There was a problem hiding this comment.
style: Comments in markdown files will be visible to users unless properly formatted. Consider using HTML comments <!-- --> instead of # comments to prevent them from appearing in the rendered documentation.
Suggested change
|  #update with current azure UI images | |
| After you hit **Save**, select **Provision Microsoft Entra ID Users** under the **Mappings** subsection. | |
|  | |
|  #update with current azure UI images | |
| Next, adjust the mappings so you have them configured as below: | |
|  | |
|  #update with current azure UI images | |
| Finally, head to your Enterprise Application > Provisioning and set the **Provisioning Status** to **On**. | |
|  | |
|  #update with current azure UI images | |
| Alternatively, you can go to **Overview** and press **Start provisioning** to have Azure start provisioning/deprovisioning users to Infisical. | |
|  | |
|  #update with current azure UI images | |
|  <!-- update with current azure UI images --> | |
| After you hit **Save**, select **Provision Microsoft Entra ID Users** under the **Mappings** subsection. | |
|  <!-- update with current azure UI images --> | |
| Next, adjust the mappings so you have them configured as below: | |
|  <!-- update with current azure UI images --> | |
| Finally, head to your Enterprise Application > Provisioning and set the **Provisioning Status** to **On**. | |
|  <!-- update with current azure UI images --> | |
| Alternatively, you can go to **Overview** and press **Start provisioning** to have Azure start provisioning/deprovisioning users to Infisical. | |
|  <!-- update with current azure UI images --> |
Prompt To Fix With AI
This is a comment left during a code review.
Path: docs/documentation/platform/scim/azure.mdx
Line: 51:67
Comment:
**style:** Comments in markdown files will be visible to users unless properly formatted. Consider using HTML comments `<!-- -->` instead of `#` comments to prevent them from appearing in the rendered documentation.
```suggestion
 <!-- update with current azure UI images -->
After you hit **Save**, select **Provision Microsoft Entra ID Users** under the **Mappings** subsection.
 <!-- update with current azure UI images -->
Next, adjust the mappings so you have them configured as below:
 <!-- update with current azure UI images -->
Finally, head to your Enterprise Application > Provisioning and set the **Provisioning Status** to **On**.
 <!-- update with current azure UI images -->
Alternatively, you can go to **Overview** and press **Start provisioning** to have Azure start provisioning/deprovisioning users to Infisical.
 <!-- update with current azure UI images -->
```
How can I resolve this? If you propose a fix, please make it concise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#Description
Customer reported that Azure UI has changed around SCIM. Need to put more recent images to reflect the actual use case.