Skip to content

Commit f30a50b

Browse files
committed
perf: reduce the lodash packing volume
1 parent 29c8434 commit f30a50b

File tree

6 files changed

+64
-64
lines changed

6 files changed

+64
-64
lines changed

packages/hooks/src/useAsyncOrder/demo/demo.vue

Lines changed: 56 additions & 56 deletions
Original file line numberDiff line numberDiff line change
@@ -8,66 +8,66 @@
88
</template>
99

1010
<script lang="ts" setup>
11-
import { ref } from 'vue'
12-
import { useAsyncOrder } from 'vue-hooks-plus'
11+
import { ref } from 'vue'
12+
import { useAsyncOrder } from 'vue-hooks-plus'
1313
14-
const error = ref<number>(0)
15-
const list = ref<string[]>([])
14+
const error = ref<number>(0)
15+
const list = ref<string[]>([])
1616
17-
function getUsername(): Promise<string> {
18-
return new Promise((resolve, reject) => {
19-
setTimeout(() => {
20-
resolve('No.1')
21-
}, 3000)
22-
})
23-
}
17+
function getUsername(): Promise<string> {
18+
return new Promise((resolve, reject) => {
19+
setTimeout(() => {
20+
resolve('No.1')
21+
}, 3000)
22+
})
23+
}
2424
25-
function getUsername2(): Promise<string> {
26-
return new Promise((resolve, reject) => {
27-
setTimeout(() => {
28-
resolve('No.2')
29-
}, 2000)
30-
})
31-
}
25+
function getUsername2(): Promise<string> {
26+
return new Promise((resolve, reject) => {
27+
setTimeout(() => {
28+
resolve('No.2')
29+
}, 2000)
30+
})
31+
}
3232
33-
function getUsername3(): Promise<string> {
34-
return new Promise((resolve, reject) => {
35-
setTimeout(() => {
36-
resolve('No.3')
37-
}, 2000)
38-
})
39-
}
33+
function getUsername3(): Promise<string> {
34+
return new Promise((resolve, reject) => {
35+
setTimeout(() => {
36+
resolve('No.3')
37+
}, 2000)
38+
})
39+
}
4040
41-
useAsyncOrder({
42-
task: [
43-
resolve => {
44-
getUsername().then(res => {
45-
resolve?.(res)
46-
})
47-
},
48-
resolve => {
49-
getUsername2().then(res => {
50-
resolve?.(res)
51-
})
52-
},
53-
(_, reject) => {
54-
getUsername2().then(() => {
55-
reject?.({ err: 'error' })
56-
})
41+
useAsyncOrder({
42+
task: [
43+
resolve => {
44+
getUsername().then(res => {
45+
resolve?.(res)
46+
})
47+
},
48+
resolve => {
49+
getUsername2().then(res => {
50+
resolve?.(res)
51+
})
52+
},
53+
(_, reject) => {
54+
getUsername2().then(() => {
55+
reject?.({ err: 'error' })
56+
})
57+
},
58+
(_, reject) => {
59+
getUsername3().then(() => {
60+
reject?.({ error: 'error' })
61+
})
62+
},
63+
],
64+
option: {
65+
onError: err => {
66+
error.value += 1
67+
},
68+
onSuccess: res => {
69+
list.value.push(res as string)
70+
},
5771
},
58-
(_, reject) => {
59-
getUsername3().then(() => {
60-
reject?.({ error: 'error' })
61-
})
62-
},
63-
],
64-
option: {
65-
onError: err => {
66-
error.value += 1
67-
},
68-
onSuccess: res => {
69-
list.value.push(res as string)
70-
},
71-
},
72-
})
72+
})
7373
</script>

packages/hooks/src/useAsyncOrder/index.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,6 @@ export default function useAsyncOrder({ task, option }: UseAsyncOrderType) {
5050
}
5151
}
5252
const runTask = () => {
53-
// eslint-disable-next-line @typescript-eslint/no-extra-semi
5453
Array(...task.keys())?.reduce((promise, index) => {
5554
const promise_ = promise.then((res: any) => {
5655
if (!res?.error) {

packages/hooks/src/useEventEmitter/event.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import _ from 'lodash'
1+
import cloneDeep from 'lodash/cloneDeep'
22
import { ref, watchEffect } from 'vue'
33

44
type SubscriptionParams<T = any> = {
@@ -52,13 +52,13 @@ class EventEmitter<T> {
5252
const subscriptionValuesCallback = this.subscriptions.get(event)
5353
subscriptionValuesCallback?.forEach(callback => {
5454
callback?.({
55-
params: _.cloneDeep(args) as any,
55+
params: cloneDeep(args) as any,
5656
event,
5757
})
5858
})
5959

6060
this.emitEffectCache.set(event, {
61-
params: _.cloneDeep(args) as any,
61+
params: cloneDeep(args) as any,
6262
event,
6363
})
6464
} else throw new TypeError('event must be string or number !')

packages/hooks/src/useKeyPress/index.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
import { ref } from 'vue'
2-
import { isFunction, isNumber, isString } from 'lodash'
2+
// import { isFunction, isNumber, isString } from 'lodash'
33
import { BasicTarget, getTargetElement } from '../utils/domTarget'
44
import useDeepCompareEffectWithTarget from '../utils/useDeepCompareWithTarget'
5+
import { isNumber, isFunction, isString } from '../utils'
56

67
export type UseKeyPressKeyPredicate = (event: KeyboardEvent) => boolean
78
export type UseKeyPressKeyType = number | string

packages/hooks/src/useRequest/plugins/useDebouncePlugin.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,13 @@ const useDebouncePlugin: UseRequestPlugin<unknown, unknown[]> = (
1414
const debounceTrailing_ = unref(debounceTrailing)
1515
const debounceMaxWait_ = unref(debounceMaxWait)
1616
if (debounceLeading_ !== undefined) {
17-
ret.leading =debounceLeading_;
17+
ret.leading = debounceLeading_;
1818
}
1919
if (debounceTrailing_ !== undefined) {
2020
ret.trailing = debounceTrailing_
2121
}
2222
if (debounceMaxWait_ !== undefined) {
23-
ret.maxWait =debounceMaxWait_;
23+
ret.maxWait = debounceMaxWait_;
2424
}
2525
return ret;
2626
});

packages/use-worker/vite.config.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ export default defineConfig({
2121
},
2222
chunkSizeWarningLimit: 1000,
2323
rollupOptions: {
24-
external: ['vue', 'lodash/isEqual'],
24+
external: ['vue'],
2525
output: {
2626
globals: {
2727
vue: 'Vue',

0 commit comments

Comments
 (0)