BUG: Avoid mismatched size on Windows by specifying binary text format

dzenanz · dzenanz · commit fb47826c002e · 2025-03-25T16:38:36.000-04:00
The error message was:

Error: Could not read output log file 'C:/Misc/ITK-IOOpenSlide-vs22/Testing/Temporary/IOOpenSlide/MetaDataTest.txt'.

and it was caused by failure of fileStream.read() on line 64.
diff --git a/test/itkOpenSlideTestMetaData.cxx b/test/itkOpenSlideTestMetaData.cxx
@@ -51,7 +51,7 @@ ReadFileStripCR(const char * p_cFileName, std::vector<char> & vBuffer)
 {
   vBuffer.clear();
 
-  std::ifstream fileStream(p_cFileName);
+  std::ifstream fileStream(p_cFileName, std::ios::binary);
   if (!fileStream)
     return false;
 

Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,7 @@ ReadFileStripCR(const char * p_cFileName, std::vector<char> & vBuffer)`
`51`	`51`	`{`
`52`	`52`	`vBuffer.clear();`
`53`	`53`
`54`		`- std::ifstream fileStream(p_cFileName);`
	`54`	`+ std::ifstream fileStream(p_cFileName, std::ios::binary);`
`55`	`55`	`if (!fileStream)`
`56`	`56`	`return false;`
`57`	`57`