Maintain backward compatibility with pre-Merkle tree manifest format #8
+173
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcelamelara
approved these changes
Oct 10, 2025
There was a problem hiding this comment.
Thanks @sandlbn ! I have only a minor comment about renaming include_metadata to something like include_tlog_metadata for clarity, otherwise this LGTM.
| RUN groupadd -r appuser && useradd -r -g appuser appuser | ||
|
|
||
| # Create data directory and set ownership BEFORE switching to appuser | ||
| RUN mkdir -p /data && chown -R appuser:appuser /data |
There was a problem hiding this comment.
Is this duplicated from #7 ?
src/main.rs
Outdated
|
|
||
| #[derive(Debug, Deserialize)] | ||
| struct GetManifestQuery { | ||
| include_metadata: Option<bool>, |
There was a problem hiding this comment.
I assume include_metadata needs to be renamed to include_tlog_metadata in this file as well, if we make this change.
Co-authored-by: Marcela Melara <marcela.melara@intel.com>
Co-authored-by: Marcela Melara <marcela.melara@intel.com>
Co-authored-by: Marcela Melara <marcela.melara@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After adding Merkle tree support, the API response format changed:
content_format,sequence_number,hash,signaturemanifest_json→ exposed asmanifest_jsonin APIAdded backward-compatible API response format while preserving Merkle tree functionality:
#[serde(rename = "manifest")]onmanifest_jsonfield#[serde(skip_serializing_if)]to hide metadata fields?include_metadata=truequery parameter#[serde(default)]for deserialization of legacy data