Skip to content

Context Parameters Refactor #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

christopherngutierrez
Copy link
Contributor

Proposed changes

  • Updates context parameters
  • Removes rns_delta
  • New format for context: CONTEXT BGV 16384 <key_rns> <current_rns>
  • Example: CONTEXT BGV 16384 3 2

Types of changes

What types of changes does your code introduce to the HE Toolkit project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you are unsure about any of them, do not hesitate to ask. We are
here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING agreement
  • Current formatting and unit tests / base functionality passes locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

@faberga faberga requested a review from joserochh March 5, 2025 22:03
@faberga
Copy link
Collaborator

faberga commented Mar 6, 2025

Closing this PR as the code still needs more work.

@faberga faberga closed this Mar 6, 2025
@faberga faberga deleted the christopherngutierrez/context-params-refactor branch April 28, 2025 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants