Skip to content

Flavio/refactor docs and tutorial #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 7, 2025
Merged

Conversation

faberga
Copy link
Collaborator

@faberga faberga commented Mar 7, 2025

Proposed changes

Documentation and Tutorials update to match changes in PR (#64).

Types of changes

What types of changes does your code introduce to the HE Toolkit project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you are unsure about any of them, do not hesitate to ask. We are
here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING agreement
  • Current formatting and unit tests / base functionality passes locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

faberga added 3 commits March 7, 2025 15:36
Signed-off-by: Flavio Bergamaschi <flavio@intel.com>
Signed-off-by: Flavio Bergamaschi <flavio@intel.com>
Signed-off-by: Flavio Bergamaschi <flavio@intel.com>
@joserochh
Copy link

joserochh commented Mar 7, 2025

Why many of the .ker files are still there empty?

@kylanerace
Copy link
Contributor

Why many of the .ker files are still there empty?

Are they empty? I mainly see the ones that were deleted

kylanerace
kylanerace previously approved these changes Mar 7, 2025
Copy link
Contributor

@kylanerace kylanerace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after correcting the file permission. I'm not seeing the blank .ker files @joserochh mentioned, but I may be overlooking them

@joserochh
Copy link

Why many of the .ker files are still there empty?

Are they empty? I mainly see the ones that were deleted

Oh that's right, my bad.

joserochh
joserochh previously approved these changes Mar 7, 2025
Signed-off-by: Flavio Bergamaschi <flavio@intel.com>
@faberga faberga self-assigned this Mar 7, 2025
Copy link
Contributor

@kylanerace kylanerace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typos fixed and otherwise. LGTM

@faberga faberga merged commit c6c6f4b into main Mar 7, 2025
6 checks passed
@faberga faberga deleted the flavio/refactor-docs-and-tutorial branch March 7, 2025 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants