-
Notifications
You must be signed in to change notification settings - Fork 3
Flavio/refactor docs and tutorial #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Flavio Bergamaschi <flavio@intel.com>
Signed-off-by: Flavio Bergamaschi <flavio@intel.com>
Signed-off-by: Flavio Bergamaschi <flavio@intel.com>
Why many of the .ker files are still there empty? |
Are they empty? I mainly see the ones that were deleted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after correcting the file permission. I'm not seeing the blank .ker files @joserochh mentioned, but I may be overlooking them
Oh that's right, my bad. |
Signed-off-by: Flavio Bergamaschi <flavio@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typos fixed and otherwise. LGTM
Proposed changes
Documentation and Tutorials update to match changes in PR (#64).
Types of changes
What types of changes does your code introduce to the HE Toolkit project?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creatingthe PR. If you are unsure about any of them, do not hesitate to ask. We are
here to help! This is simply a reminder of what we are going to look for before
merging your code.