Add support for D436 #13855
Merged
Add support for D436 #13855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OhadMeir
reviewed
Mar 23, 2025
| + /* Intel D436 depth camera */ | ||
| + { .match_flags = USB_DEVICE_ID_MATCH_DEVICE | ||
| + | USB_DEVICE_ID_MATCH_INT_INFO, | ||
| + .idVendor = 0x8086, |
There was a problem hiding this comment.
Does tabs/spaces number matter here?
OhadMeir
reviewed
Mar 23, 2025
| @@ -361,7 +361,41 @@ namespace librealsense | |||
| p.depth_gain.gain = 16.f; | |||
| } | |||
|
|
|||
| void default_430(preset& p) | |||
| void default_430_color_only(preset& p) | |||
There was a problem hiding this comment.
Names are misleading. Do you want to set RGB sensor separately from Depth sensor? Call is default_xxx_rgb and default_xxx_depth.
Notice p.color_control and p.cc are actually depth sensor settings, see https://github.com/IntelRealSense/librealsense/blob/development/src/ds/advanced_mode/advanced_mode.cpp#L787
OhadMeir
reviewed
Mar 23, 2025
Comment on lines
+164
to
165
| {RS436_PID, "5.16.3.3" }, // TODO - update final required FW version | ||
| {RS416_PID, "5.8.15.0" }, |
There was a problem hiding this comment.
Is the "TODO" still relevant?
OhadMeir
reviewed
Mar 23, 2025
| @@ -1356,6 +1233,15 @@ namespace librealsense | |||
| return matcher_factory::create(RS2_MATCHER_DEFAULT, streams); | |||
| } | |||
|
|
|||
| std::shared_ptr<matcher> rs436_device::create_matcher(const frame_holder& frame) const | |||
| { | |||
| std::vector<stream_interface*> streams = { _depth_stream.get() , _left_ir_stream.get() , _right_ir_stream.get(), _color_stream.get() }; | |||
There was a problem hiding this comment.
Why do we need all this code duplication?
Can rs436/435i/430i_device etc call a common "create_mm_streams" function?
OhadMeir
reviewed
Mar 23, 2025
| @@ -267,7 +267,8 @@ namespace rs2 | |||
|
|
|||
| auto dev_name = get_device_name(dev); | |||
|
|
|||
| if( ( dev.is<update_device>() || is_upgradeable( fw, recommended_fw_ver) ) ) | |||
| // TODO - D436. Don't suggest to update FW as it doesn't support D436. Revert after next release with bundle supporting FW | |||
| if( ( dev.is<update_device>() || is_upgradeable( fw, recommended_fw_ver) ) && pid != "1156") //0x1156 is pid for D436 | |||
There was a problem hiding this comment.
Better to use camera name, not PID.
OhadMeir
approved these changes
Mar 23, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracked on [RSDEV-3024]