feat: implement "mutable" transform holder for random rotations #3173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dordsor21
commented
Apr 13, 2025
dordsor21
commented
- also implement random rotation to schematic loadall
- "mutable" transform allows random rotation of schematics outside of clipboard brush
- fixes Function not add, while it is announced in the wiki. #3129
SirYwell
reviewed
May 1, 2025
| * | ||
| * @since TODO | ||
| */ | ||
| default void mutate() { |
There was a problem hiding this comment.
I'm not sure if I like this design, it's somewhat invasive. Would it make sense to have a static method in MutatingOperationTransform instead that handles that part instead?
|
Hmm how does that deal with multithreading? |
It doesn't, but currently there should be no reason for there to be any kind of contention, and regardless multi-threading should probably be handled implementation-specifically |
|
What about |
- also implement random rotation to schematic loadall - "mutable" transform allows random rotation of schematics outside of clipboard brush - fixes #3129
dordsor21
force-pushed
the
feat/mutable-transform-holder
branch
from
6ae1449 to
3d4ea3c
Compare
SirYwell
reviewed
Jun 2, 2025
...e/src/main/java/com/fastasyncworldedit/core/function/pattern/RandomFullClipboardPattern.java
Outdated
Show resolved
Hide resolved
worldedit-core/src/main/java/com/sk89q/worldedit/session/PasteBuilder.java
Outdated
Show resolved
Hide resolved
SirYwell
approved these changes
Jun 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.