Skip to content

Conversation

TheMeinerLP
Copy link
Member

@TheMeinerLP TheMeinerLP commented Apr 29, 2023

Overview

Fixes #2140
Fixes #2427

Description

This PR included the fix for passenger of entities and also leashs for other entities.
That means now //copy -e and //paste -e will work to 99% correct now for entities except some edge cases.

Submitter Checklist

  • Make sure you are opening from a topic branch (/feature/fix/docs/ branch (right side)) and not your main branch.
  • Ensure that the pull request title represents the desired changelog entry.
  • New public fields and methods are annotated with @since TODO.
  • I read and followed the contribution guidelines.

@TheMeinerLP TheMeinerLP requested a review from a team as a code owner April 29, 2023 14:21
@github-actions github-actions bot added the Bugfix This PR fixes a bug label Apr 29, 2023
@TheMeinerLP
Copy link
Member Author

I tested each of them on a Plot world

@LedariaTim1
Copy link

LedariaTim1 commented May 13, 2023

i just compiled your bugfix and tested it, the entities including passanger are now copied, but they are now both independent entities and no longer mounted. in my case the pig is no longer sitting on the invisible armorstand and can be moved around
image
image

@TheMeinerLP
Copy link
Member Author

Bump!
Tested with 1.20.1

@TheMeinerLP TheMeinerLP closed this Dec 2, 2023
@TheMeinerLP TheMeinerLP deleted the bugfix/2140 branch December 2, 2023 11:12
@TheMeinerLP TheMeinerLP restored the bugfix/2140 branch December 2, 2023 11:13
@TheMeinerLP TheMeinerLP reopened this Dec 2, 2023
@TheMeinerLP TheMeinerLP requested a review from SirYwell December 2, 2023 11:43
@seercle
Copy link

seercle commented Jan 12, 2024

Hey, do we have any news about this? This fix would be very useful for builders who use Block Display Studio to create structures.

Copy link

Please take a moment and address the merge conflicts of your pull request. Thanks!

Copy link

Please take a moment and address the merge conflicts of your pull request. Thanks!

@TehManu
Copy link

TehManu commented Mar 21, 2025

Hey, this solution does not work with vehicles because the passengers missing their NBT data. I'm not sure but i think the real problem is here.
image

The method only saves NBT data when the entity is not a passenger
image

Maybe i might be wrong, but i tested it with saveWithoutId() and it worked with copying the passengers and they also had their correct nbt data being applied.

@TheMeinerLP
Copy link
Member Author

Hey, this solution does not work with vehicles because the passengers missing their NBT data. I'm not sure but i think the real problem is here. image

The method only saves NBT data when the entity is not a passenger image

Maybe i might be wrong, but i tested it with saveWithoutId() and it worked with copying the passengers and they also had their correct nbt data being applied.

Thanks for reporting this. I will take a look

@TehManu
Copy link

TehManu commented Mar 26, 2025

I found another way to also get the same result in the PaperweightGetBlocks class, replace the code after line 672 with the following one.

image

@TehManu
Copy link

TehManu commented Apr 8, 2025

Hi, are there any updates on this? Our players are waiting for a fix. @TheMeinerLP

@TheMeinerLP
Copy link
Member Author

Hi, are there any updates on this? Our players are waiting for a fix. @TheMeinerLP

Sorry, I was on sick leave, and I am not yet 100% recovered

@Mrpressed
Copy link

Thank you for working on this, ive been waiting for a fix.

@TehManu
Copy link

TehManu commented Apr 9, 2025

Sorry, I was on sick leave, and I am not yet 100% recovered

Thank you for your work, get well soon! Could you please take a look at the nbt data issue when copying passengers? I would really appreciate if you could fix this too.

@Mrpressed
Copy link

Fixing the NBT issue would be amazing, it's what's holding back the development of my server currently.

@kylelaverty
Copy link

Sorry, I was on sick leave, and I am not yet 100% recovered

Thank you for working on this.

@TehManu
Copy link

TehManu commented May 5, 2025

Hi @TheMeinerLP, any updates on this? It's a while since there was any progress on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bugfix This PR fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Copy/Paste with passenger entities Entities containing data of other entities don't work with copy and paste operation

8 participants