-
-
Notifications
You must be signed in to change notification settings - Fork 264
feat: implement "mutable" transform holder for random rotations #3173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
108 changes: 108 additions & 0 deletions
108
...ain/java/com/fastasyncworldedit/core/math/transform/MutatingOperationTransformHolder.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,108 @@ | ||
| package com.fastasyncworldedit.core.math.transform; | ||
|
|
||
| import com.sk89q.worldedit.math.Vector3; | ||
| import com.sk89q.worldedit.math.transform.CombinedTransform; | ||
| import com.sk89q.worldedit.math.transform.Transform; | ||
|
|
||
| import java.util.function.Function; | ||
|
|
||
| /** | ||
| * Applies an operation on a {@link Transform} when {@link MutatingOperationTransformHolder#mutate()} is called. Typically at | ||
| * the start of an operation. | ||
| * | ||
| * @param <T> transform to mutate type | ||
| * @since TODO | ||
| */ | ||
| public class MutatingOperationTransformHolder<T extends Transform> implements Transform { | ||
|
|
||
| private final Function<? super T, ? extends T> operation; | ||
| private T transform; | ||
|
|
||
| /** | ||
| * Construct new instance | ||
| * | ||
| * @param transform transform to mutate | ||
| * @since TODO | ||
| */ | ||
| public MutatingOperationTransformHolder(T transform, Function<? super T, ? extends T> operation) { | ||
| this.transform = transform; | ||
| this.operation = operation; | ||
| } | ||
|
|
||
| /** | ||
| * Perform a mutation on the given transform, if supported. Else, does nothing. This mutation will depend on the specific | ||
| * transform implementation. | ||
| * <p> | ||
| * Implementation detail: it may be possible for this method to be called multiple times before an operation actually occurs. | ||
| * | ||
| * @param transform Transform to transform | ||
| * @since TODO | ||
| */ | ||
| public static Transform transform(Transform transform) { | ||
| return transform(transform, false); | ||
| } | ||
|
|
||
| /** | ||
| * Perform a mutation on the given transform, if supported. Else, does nothing. This mutation will depend on the specific | ||
| * transform implementation. | ||
| * <p> | ||
| * Implementation detail: it may be possible for this method to be called multiple times before an operation actually occurs. | ||
| * | ||
| * @param transform Transform to transform | ||
| * @param parallel If the context is potentially parallel, meaning the given transform will be copied if required | ||
| * @since TODO | ||
| */ | ||
| public static Transform transform(Transform transform, boolean parallel) { | ||
| return switch (transform) { | ||
| case MutatingOperationTransformHolder<?> mutating -> parallel ? mutating.copy().mutate() : mutating.mutate(); | ||
| case CombinedTransform combined -> { | ||
| if (!parallel) { | ||
| combined.getTransforms().forEach(t -> transform(t, false)); | ||
| yield combined; | ||
| } | ||
| yield new CombinedTransform(combined.getTransforms().stream().map(t -> transform(t, true)).toList()); | ||
| } | ||
| default -> transform; | ||
| }; | ||
| } | ||
|
|
||
| /** | ||
| * Apply the mutator to the transform | ||
| * | ||
| * @since TODO | ||
| */ | ||
| public MutatingOperationTransformHolder<T> mutate() { | ||
| if (operation != null) { | ||
| transform = operation.apply(transform); | ||
| } | ||
| return this; | ||
| } | ||
|
|
||
| @Override | ||
| public boolean isIdentity() { | ||
| return transform.isIdentity(); | ||
| } | ||
|
|
||
| @Override | ||
| public Vector3 apply(final Vector3 input) { | ||
| return transform.apply(input); | ||
| } | ||
|
|
||
| @Override | ||
| public Transform inverse() { | ||
| return transform.inverse(); | ||
| } | ||
|
|
||
| @Override | ||
| public Transform combine(final Transform other) { | ||
| return transform.combine(other); | ||
| } | ||
|
|
||
| public MutatingOperationTransformHolder<T> copy() { | ||
| // I don't think we should see nested mutating, but you never know | ||
| T transform = this.transform instanceof MutatingOperationTransformHolder<?> mutating ? (T) mutating.copy() : | ||
| this.transform; | ||
| return new MutatingOperationTransformHolder<>(transform, operation); | ||
| } | ||
|
|
||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.