Skip to content

Conversation

EvertBt
Copy link
Contributor

@EvertBt EvertBt commented Oct 3, 2025

Overview

Fix Unwanted console logging when accessing RollbackOptimizedHistory

Fixes #3321

Description

Removed the logging call in one of the RollbackOptimizedHistory constructors, removed the now unused logger.

Submitter Checklist

  • [v] Make sure you are opening from a topic branch (/feature/fix/docs/ branch (right side)) and not your main branch.
  • [v] Ensure that the pull request title represents the desired changelog entry.
  • [v] New public fields and methods are annotated with @since TODO.
  • [v] I read and followed the contribution guidelines.

@EvertBt EvertBt requested a review from a team as a code owner October 3, 2025 14:34
@github-actions github-actions bot added the Bugfix This PR fixes a bug label Oct 3, 2025
@PierreSchwang
Copy link
Member

I think the logger import should be removed? No idea why spotless isn't failing the CI

@EvertBt
Copy link
Contributor Author

EvertBt commented Oct 9, 2025

I think the logger import should be removed? No idea why spotless isn't failing the CI

Right, my bad. To make sure, you are talking about these 2?
com.sk89q.worldedit.internal.util.LogManagerCompat;
org.apache.logging.log4j.Logger;

@SirYwell
Copy link
Member

I think the logger import should be removed? No idea why spotless isn't failing the CI

Right, my bad. To make sure, you are talking about these 2? com.sk89q.worldedit.internal.util.LogManagerCompat; org.apache.logging.log4j.Logger;

Any unused import can be removed in that class. If it's only these two, perfect :)

@NotMyFault NotMyFault requested a review from a team October 13, 2025 15:35
@PierreSchwang PierreSchwang enabled auto-merge (squash) October 16, 2025 20:57
@PierreSchwang PierreSchwang merged commit 858544c into IntellectualSites:main Oct 16, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bugfix This PR fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unwanted console logging when accessing RollbackOptimizedHistory

4 participants