bugfixes after refactor

Author: benedekkupper

c2usb/c2usb.hpp

@@ -79,8 +79,7 @@ class result
     static inline constexpr std::errc BUSY = static_cast<std::errc>(EBUSY);
     static inline constexpr std::errc NO_CONNECTION = static_cast<std::errc>(ENOTCONN);
     static inline constexpr std::errc NO_MEMORY = static_cast<std::errc>(ENOMEM);
-    bool operator==(std::errc err) const { return code_ == -static_cast<int>(err); }
-    bool operator!=(std::errc err) const { return code_ != -static_cast<int>(err); }
+    constexpr bool operator==(const result& other) const = default;
 };
 
 /// @brief  The interface base class is used by interface subclasses,

c2usb/port/zephyr/udc_mac.cpp

@@ -224,7 +224,10 @@ void udc_mac::ctrl_stall(net_buf* buf, int err)
         addr = endpoint::address::control_out();
     }
     [[maybe_unused]] auto ret = ep_set_stall(addr);
-    net_buf_unref(buf);
+    if (buf)
+    {
+        net_buf_unref(buf);
+    }
 }
 
 net_buf* udc_mac::ctrl_buffer_allocate(net_buf* buf)
@@ -259,6 +262,10 @@ net_buf* udc_mac::ctrl_buffer_allocate(net_buf* buf)
             net_buf_frag_add(buf, status);
         }
     }
+    else if (status != nullptr)
+    {
+        net_buf_unref(status);
+    }
     return buf;
 }
 
@@ -319,8 +326,11 @@ void udc_mac::process_ctrl_ep_event(net_buf* buf, const udc_buf_info& info)
         stall_flags_.clear(endpoint::address::control_in());
 
         std::memcpy(&request(), buf->data, sizeof(request()));
+#if CONFIG_C2USB_UDC_MAC_LOG_LEVEL >= LOG_LEVEL_DBG
+        // logged when DBG level is selected, but without the extra details of LOG_DBG()
         LOG_INF("CTRL EP setup: %02x %02x %04x %u", request().bmRequestType, request().bRequest,
                 (uint16_t)request().wValue, (uint16_t)request().wLength);
+#endif
 
         // pop the buf chain for the next stage(s), freeing the setup buf
         buf = net_buf_frag_del(nullptr, buf);
@@ -335,6 +345,8 @@ void udc_mac::process_ctrl_ep_event(net_buf* buf, const udc_buf_info& info)
             buf = ctrl_buffer_allocate(buf);
             if (buf == nullptr)
             {
+                // TODO: instead try to consume all events from the queue, and only process the last
+                // CTRL EP event
                 LOG_ERR("ctrl_buf alloc fail, stall");
                 return ctrl_stall(buf);
             }