Skip to content

Update LedgerPeerSnapshot #5199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Update LedgerPeerSnapshot #5199

wants to merge 8 commits into from

Conversation

@crocodile-dentist
Copy link
Contributor

@crocodile-dentist crocodile-dentist commented Sep 17, 2025 •
edited
Loading

Description

  • LedgerPeerSnapshot is extended to contain either all ledger peers or big ledger peers
  • Added Point (slot w/ block hash) and network magic
  • new snapshot encoding functions to move away from CBOR instances when NtC V22 support is dropped
  • test updates

Checklist

Quality

  • Commit sequence makes sense and have useful messages, see ref.
  • New tests are added and existing tests are updated.
  • Self-reviewed the PR.

Maintenance

  • Linked an issue or added the PR to the current sprint of ouroboros-network project.
  • Added labels.
  • Updated changelog files.
  • The documentation has been properly updated, see ref.

@crocodile-dentist crocodile-dentist self-assigned this Sep 17, 2025
@crocodile-dentist crocodile-dentist requested a review from a team as a code owner September 17, 2025 14:02
@github-project-automation github-project-automation bot moved this to In Progress in Ouroboros Network Sep 17, 2025
@crocodile-dentist crocodile-dentist marked this pull request as draft September 17, 2025 14:02
@crocodile-dentist crocodile-dentist force-pushed the mw/ledgerpeersnapshot-hash branch from 5e82f56 to 7c8ef20 Compare September 24, 2025 17:21
@crocodile-dentist crocodile-dentist force-pushed the mw/ledgerpeersnapshot-hash branch 5 times, most recently from 1a0a507 to f5f6e0c Compare October 28, 2025 15:29
@crocodile-dentist crocodile-dentist changed the title use block hash to verify ledger peer snapshot Update LedgerPeerSnapshot to contain block hash and network magic Oct 28, 2025
@crocodile-dentist crocodile-dentist marked this pull request as ready for review October 28, 2025 15:33
@crocodile-dentist crocodile-dentist force-pushed the mw/ledgerpeersnapshot-hash branch 11 times, most recently from 777d3ce to fe2b3b3 Compare October 31, 2025 08:50
@crocodile-dentist crocodile-dentist changed the title Update LedgerPeerSnapshot to contain block hash and network magic Update LedgerPeerSnapshot Oct 31, 2025
@crocodile-dentist crocodile-dentist force-pushed the mw/ledgerpeersnapshot-hash branch 3 times, most recently from 6a82935 to da7e084 Compare November 4, 2025 09:00
@crocodile-dentist crocodile-dentist requested a review from a team as a code owner November 4, 2025 14:01
@crocodile-dentist crocodile-dentist force-pushed the mw/ledgerpeersnapshot-hash branch from 8a05a4a to e75d112 Compare November 4, 2025 14:11
@crocodile-dentist crocodile-dentist force-pushed the mw/ledgerpeersnapshot-hash branch from e75d112 to 55cc76d Compare November 4, 2025 14:22
@crocodile-dentist
api: add Point to LedgerPeerSnapshot
fb700b0 
api: facilitate future removal of a few {From,To}CBOR instances

Added explicit encode/decode functions such that CBOR instances
can be easily removed when ntc v22 is no longer supported
@crocodile-dentist
o-n: remove dependence on cardano-slotting
bb1fd75
@crocodile-dentist
o-n tests: remove dependence on cardano-slotting
ea88881
@crocodile-dentist
peer-selection: verify peer snapshot with hash
2f8351b
@crocodile-dentist
Bump to NodeToClientV_23
c115e26 
Supports block hash in cbor encoding of ledger peer snapshot
@crocodile-dentist
dmq: integrate LedgerPeerSnapshot changes
d345071
@crocodile-dentist
scriv
7f45b95
@crocodile-dentist
nix: fix static build
56f499f
@crocodile-dentist crocodile-dentist force-pushed the mw/ledgerpeersnapshot-hash branch from 55cc76d to 56f499f Compare November 5, 2025 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@crocodile-dentist crocodile-dentist

Labels

None yet

Projects

Ouroboros Network
Status: In Progress

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@crocodile-dentist