Skip to content

fixed AvatarHover plugin#165

Open
jericjan wants to merge 1 commit intoInve1951:masterfrom
jericjan:master
Open

fixed AvatarHover plugin#165
jericjan wants to merge 1 commit intoInve1951:masterfrom
jericjan:master

Conversation

@jericjan
Copy link
Copy Markdown

@jericjan jericjan commented Feb 16, 2022

all the class names changed so i just updated them

ignore the block comment saying //doesn't work still???. it does work. you just need the Guilds option enabled in Avatar Hover's settings

all the class names changed so i just updated them
@ThatFirey
Copy link
Copy Markdown

The avatars get pixelated when I hover on them

top = size > boundsWindow.height ? (boundsWindow.height - size) / 2 : boundsTarget.bottom + size > boundsWindow.height ? boundsTarget.top - size : boundsTarget.bottom;

if ("none" === (imageUrl = (((ref = target.querySelector("img")) != null ? ref.src : void 0) || target.src || getComputedStyle(target).backgroundImage.match(/^url\((["']?)(.+)\1\)$/)[2]).replace(/\?size=\d{2,4}\)?$/, `?size=${size}`))) {
if ("none" === (imageUrl = (((ref = target.querySelector("img")) != null ? ref.src : void 0) || target.src || getComputedStyle(target).backgroundImage.match(/^url\((["']?)(.+)\1\)$/)[2]).replace(/\?size=\d{3,4}\)?$/, `?size=${size}`))) {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change makes it so that some avatars stay at 28px because 28 is a 2 digit number and not 3.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change makes avatars pixelated, you shouldn't do it

@Kyhze
Copy link
Copy Markdown

Kyhze commented Mar 20, 2022

Looks like it broke again...

@jericjan
Copy link
Copy Markdown
Author

Works fine for me rn

@Kyhze
Copy link
Copy Markdown

Kyhze commented Mar 21, 2022

My bad, you're right. The original plugin was active for some reason. I re-applied this one instead and now everything works correctly. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants