Revert "Issue #1146: Revert initial change. Do not set toAutoSort by default, but only if OnCompareNodes is assigned"

This reverts commit 6ed0528.

Author: joachimmarder

Source/VirtualTrees.BaseTree.pas

@@ -913,7 +913,6 @@   TBaseVirtualTree = class abstract(TVTBaseAncestor)
     function IsStored_Indent: Boolean;
     function IsStored_Margin: Boolean;
     function IsStored_TextMargin: Boolean;
-    procedure SetOnCompareNodes(const Value: TVTCompareEvent);
   protected
     FFontChanged: Boolean;                       // flag for keeping informed about font changes in the off screen buffer   // [IPK] - private to protected
     procedure AutoScale(); virtual;
@@ -1310,7 +1309,7 @@   TBaseVirtualTree = class abstract(TVTBaseAncestor)
     property OnColumnWidthDblClickResize: TVTColumnWidthDblClickResizeEvent read FOnColumnWidthDblClickResize
       write FOnColumnWidthDblClickResize;
     property OnColumnWidthTracking: TVTColumnWidthTrackingEvent read FOnColumnWidthTracking write FOnColumnWidthTracking;
-    property OnCompareNodes: TVTCompareEvent read FOnCompareNodes write SetOnCompareNodes;
+    property OnCompareNodes: TVTCompareEvent read FOnCompareNodes write FOnCompareNodes;
     property OnCreateDataObject: TVTCreateDataObjectEvent read FOnCreateDataObject write FOnCreateDataObject;
     property OnCreateDragManager: TVTCreateDragManagerEvent read FOnCreateDragManager write FOnCreateDragManager;
     property OnCreateEditor: TVTCreateEditorEvent read FOnCreateEditor write FOnCreateEditor;
@@ -5659,12 +5658,6 @@ procedure TBaseVirtualTree.SetOffsetY(const Value: TDimension);
 
 //----------------------------------------------------------------------------------------------------------------------
 
-procedure TBaseVirtualTree.SetOnCompareNodes(const Value: TVTCompareEvent);
-begin
-  FOnCompareNodes := Value;
-  Self.TreeOptions.AutoOptions := TreeOptions.AutoOptions + [TVTAutoOption.toAutoSort]; // See issue #1146
-end;
-
 procedure TBaseVirtualTree.SetOnPrepareButtonImages(const Value: TVTPrepareButtonImagesEvent);
 begin
   FOnPrepareButtonImages := Value;
@@ -22533,6 +22526,8 @@ procedure TBaseVirtualTree.SortTree(Column: TColumnIndex; Direction: TSortDirect
 begin
   if RootNode.TotalCount <= 2 then
     Exit;//Nothing to do if there are one or zero nodes. RootNode.TotalCount is 1 if there are no nodes in the treee as the root node counts too here.
+  if not Assigned(OnCompareNodes) then
+    exit;// no sorting will take place without an event handler. Issue #1146
 
   if not Assigned(FRoot.FirstChild) then
     Exit; // Sorting should not initialize the root nodes

Source/VirtualTrees.Types.pas

@@ -774,7 +774,7 @@   TChunkHeader = record
 const
   DefaultPaintOptions     = [toShowButtons, toShowDropmark, toShowTreeLines, toShowRoot, toThemeAware, toUseBlendedImages];
   DefaultAnimationOptions = [];
-  DefaultAutoOptions      = [toAutoDropExpand, toAutoTristateTracking, toAutoScrollOnExpand, toAutoDeleteMovedNodes, toAutoChangeScale, toAutoHideButtons];
+  DefaultAutoOptions      = [toAutoDropExpand, toAutoTristateTracking, toAutoScrollOnExpand, toAutoDeleteMovedNodes, toAutoChangeScale, toAutoSort, toAutoHideButtons];
   DefaultSelectionOptions = [toSelectNextNodeOnRemoval];
   DefaultMiscOptions      = [toAcceptOLEDrop, toFullRepaintOnResize, toInitOnSave, toToggleOnDblClick, toWheelPanning, toEditOnClick];