Fix exception when SVG icon name has no file extension#1087
Merged
DevCharly merged 1 commit intoJFormDesigner:mainfrom Jan 30, 2026
Merged
Conversation
Collaborator
|
Merged in latest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using dark themes, FlatSVGIcon attempts to insert
_darkbefore the fileextension. If the icon name does not contain a dot, this results in a
StringIndexOutOfBoundsException.This situation can easily occur if the SVG file path is provided without the
.svgextension by mistake, since the API does not enforce or validate thefile name format.
This change adds a simple guard to avoid invalid substring operations when
no file extension is present, preventing runtime exceptions while preserving
existing behavior.