Add JSDoc annotations and fix takeOutOfBase column iteration bug#163
Open
Add JSDoc annotations and fix takeOutOfBase column iteration bug#163
Conversation
Add comprehensive JSDoc documentation to all public and internal APIs including types, classes, methods, and properties across expressions, model, tableau, simplex, branch-and-cut, and external solver modules. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The takeOutOfBase function searches for a non-zero coefficient to use as a pivot column, but the loop bound was `this.height` instead of `this.width`. Since the loop iterates over columns (not rows), this caused the search to miss valid pivot columns whenever width > height (more variables than constraints), which is the common case. ~13% improvement on the heaviest benchmark problem (Vendor Selection). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
takeOutOfBase()where column iteration usedthis.heightinstead ofthis.width, causing missed pivot columns when width > height (the common case)Bug fix details
dynamic-modification.ts:55—takeOutOfBasesearches for a non-zero coefficient to pivot on by iterating columns, but the loop bound wasthis.height(number of rows) instead ofthis.width(number of columns). This truncated the search space on any problem with more variables than constraints.Performance impact
Test plan
🤖 Generated with Claude Code