Skip to content

Commit 7d56332

Browse files
lint/refactor
1 parent 4458dec commit 7d56332

2 files changed

Lines changed: 7 additions & 11 deletions

File tree

  • instrumentation/opentelemetry-instrumentation-logging/src/opentelemetry/instrumentation/logging

instrumentation/opentelemetry-instrumentation-logging/src/opentelemetry/instrumentation/logging/__init__.py

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -247,14 +247,12 @@ def record_factory(*args, **kwargs):
247247
.lower()
248248
== "true",
249249
)
250-
handler_level = kwargs.get("log_handler_level", None)
251-
if (
252-
handler_level is None
253-
and OTEL_PYTHON_LOG_HANDLER_LEVEL in environ
254-
):
255-
handler_level = _get_log_level(
256-
environ[OTEL_PYTHON_LOG_HANDLER_LEVEL]
257-
)
250+
handler_level = kwargs.get(
251+
"log_handler_level",
252+
_get_log_level(environ[OTEL_PYTHON_LOG_HANDLER_LEVEL])
253+
if OTEL_PYTHON_LOG_HANDLER_LEVEL in environ
254+
else None,
255+
)
258256
logger_provider = get_logger_provider()
259257
handler = _setup_logging_handler(
260258
logger_provider=logger_provider,

instrumentation/opentelemetry-instrumentation-logging/src/opentelemetry/instrumentation/logging/handler.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -57,12 +57,10 @@ def _setup_logging_handler(
5757
level: int | None = None,
5858
) -> LoggingHandler:
5959
handler = LoggingHandler(
60-
level=logging.NOTSET,
60+
level=level or logging.NOTSET,
6161
logger_provider=logger_provider,
6262
log_code_attributes=log_code_attributes,
6363
)
64-
if level is not None:
65-
handler.setLevel(level)
6664
logging.getLogger().addHandler(handler)
6765
_overwrite_logging_config_fns(handler)
6866
return handler

0 commit comments

Comments
 (0)