Skip to content

Improve URLDownload exception to include httpResponse details #14261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −2
Open

Improve URLDownload exception to include httpResponse details #14261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion jablib/src/main/java/org/jabref/logic/importer/fetcher/DoiFetcher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,8 @@ public Optional<BibEntry> performSearchById(String identifier) throws FetcherExc
bibtexString = URLDownload.asString(openConnection).trim();

// BibTeX entry
fetchedEntry = BibtexParser.singleFromString(bibtexString, preferences);
List<BibEntry> entries = new BibtexParser(preferences).parseEntries(bibtexString);
fetchedEntry = entries.isEmpty() ? Optional.empty() : Optional.of(entries.getFirst());
Comment on lines +152 to +153
Copy link
Member

@koppor koppor Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no URLconnection passed - please use org.jabref.logic.importer.fileformat.BibtexParser#parseEntries

Copy link
Author

@vivek1833 vivek1833 Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review. The BibtexParser class implements the Parser interface, which provides parseEntries(String) as a default method that internally converts the String to an InputStream and calls the parseEntries(InputStream) method that BibtexParser implements. There is no parseEntries(URLConnection) method available in our API. This change replaces the static singleFromString call with the BibtexParser#parseEntries.

fetchedEntry.ifPresent(this::doPostCleanup);

// Crossref has a dynamic API rate limit
Expand Down
2 changes: 1 addition & 1 deletion jablib/src/main/java/org/jabref/logic/net/URLDownload.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ public static String asString(URLConnection existingConnection) throws FetcherEx
* @param connection an existing connection
* @return the downloaded string
*/
public static String asString(Charset encoding, URLConnection connection) throws FetcherException {
private static String asString(Charset encoding, URLConnection connection) throws FetcherException {
try (InputStream input = new BufferedInputStream(connection.getInputStream());
Writer output = new StringWriter()) {
copy(input, output, encoding);
Expand Down
Loading