Add support for date ranges for BibLaTeX Date by Alex1034 · Pull Request #14289 · JabRef/jabref

Alex1034 · 2025-11-11T21:19:54Z

Summary

This pull request adds support for date ranges in BibLaTeX date fields.

Previously, JabRef only supported single dates (e.g., 2021-05-03).
With this change, JabRef now correctly parses and formats date ranges (e.g., 2020/2021, 2015-01-01/2016-12-31) in compliance with ISO 690 and BibLaTeX standards.

Steps to test

Open the entry editor and locate the Date field.
Try entering a date range, e.g.:
- 2020/2021
- 2021-05-01/2021-06-30
Save and reopen the entry.
Confirm that both start and end dates are parsed and displayed correctly.
Export the entry to ensure the field is saved as date = {2020/2021}.

Additional details

Updated Date.java to normalize and handle start/end dates.
Updated DateEditorViewModel.java to correctly format and display date ranges.
Added normalization for incomplete date ranges (e.g., "2010/" → "2010").
Updated CHANGELOG.md under the [Unreleased] section.

Changelog

I have modified CHANGELOG.md appropriately.

PR Checklist

I have followed the contributing guidelines
I have written tests for the change
I have added an entry to the changelog
I have manually tested the change in JabRef
My code follows the project’s code style and passes existing tests
I have considered security implications

Mandatory checks

[/] I own the copyright of the code submitted and I license it under the MIT license
I manually tested my changes in running JabRef (always required)
I added JUnit tests for changes (if applicable)
[/] I added screenshots in the PR description (if change is visible to the user)
I described the change in CHANGELOG.md in a way that is understandable for the average user (if change is visible to the user)
I checked the user documentation.(no changes needed)

Fixes JabRef#8902

github-actions · 2025-11-11T21:20:08Z

Hey @Alex1034!

Thank you for contributing to JabRef! Your help is truly appreciated ❤️.

We have automatic checks in place, based on which you will soon get automated feedback if any of them are failing. We also use TragBot with custom rules that scans your changes and provides some preliminary comments, before a maintainer takes a look. TragBot is still learning, and may not always be accurate. In the "Files changed" tab, you can go through its comments and just click on "Resolve conversation" if you are sure that it is incorrect, or comment on the conversation if you are doubtful.

Please re-check our contribution guide in case of any other doubts related to our contribution workflow.

Siedlerchr · 2025-11-15T14:33:06Z

jabgui/src/main/java/org/jabref/gui/fieldeditors/DateEditorViewModel.java

            @Override
            public TemporalAccessor fromString(String string) {
                if (StringUtil.isNotBlank(string)) {
+                    // ✅ Sanitize incomplete ranges (e.g., "2010/" → "2010")


remove this AI comment

koppor

Tests are missing
CHANGELOG.md entry missing

koppor · 2025-11-23T20:09:19Z

jabgui/src/main/java/org/jabref/gui/fieldeditors/DateEditorViewModel.java

+            private String sanitizeIncompleteRange(String dateString) {
+                String trimmed = dateString.trim();
+
+                if (trimmed.endsWith("/") && !trimmed.matches(".*\\d+/\\d+.*")) {
+                    LOGGER.debug("Sanitizing incomplete range (trailing slash): {}", trimmed);
+                    return trimmed.substring(0, trimmed.length() - 1).trim();
+                }
+
+                if (trimmed.startsWith("/") && !trimmed.matches(".*\\d+/\\d+.*")) {
+                    LOGGER.debug("Sanitizing incomplete range (leading slash): {}", trimmed);
+                    return trimmed.substring(1).trim();
+                }
+
+                return dateString;


This is more a logic part, not a gui part. Please search for an appropriate place in the logic package.

I would assume near org.jabref.model.entry.Date

koppor · 2025-11-23T20:11:45Z

jabgui/src/test/java/org/jabref/gui/fieldeditors/DateEditorViewModelTest.java

+    private DateEditorViewModel viewModel;
+    private StringConverter<TemporalAccessor> dateToStringConverter;
+
+    private TemporalAccessor sentinel() {


This is more a constant. Also needs to have a comment.

github-actions · 2025-12-01T00:11:23Z

Your pull request conflicts with the target branch.

Please merge with your code.
For a step-by-step guide to resolve merge conflicts, see https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/addressing-merge-conflicts/resolving-a-merge-conflict-using-the-command-line.

jablib/src/test/java/org/jabref/model/entry/DateTest.java

calixtus · 2025-12-22T16:56:04Z

@Alex1034 Please check the license checkbox in the mandatory checks section in the PR description. Otherwise this PR will be closed.

jabref-machine · 2025-12-22T16:57:47Z

Your code currently does not meet JabRef's code guidelines. We use Checkstyle to identify issues. You can see which checks are failing by locating the box "Some checks were not successful" on the pull request page. To see the test output, locate "Source Code Tests / Checkstyle (pull_request)" and click on it.

In case of issues with the import order, double check that you activated Auto Import. You can trigger fixing imports by pressing Ctrl+Alt+O to trigger Optimize Imports.

Please carefully follow the setup guide for the codestyle. Afterwards, please run checkstyle locally and fix the issues, commit, and push.

koppor · 2025-12-26T11:30:22Z

CHANGELOG.md

 - We separated the "Clean up entries" dialog into three tabs for clarity. [#13819](https://github.com/JabRef/jabref/issues/13819)
 - `JabKit`: `--porcelain` does not output any logs to the console anymore. [#14244](https://github.com/JabRef/jabref/pull/14244)
 - <kbd>Ctrl</kbd> + <kbd>Shift</kbd> + <kbd>L</kbd> now opens the terminal in the active library directory. [#14130](https://github.com/JabRef/jabref/issues/14130)
+- We improved handling of dates. [#14289](https://github.com/JabRef/jabref/pull/14289)


Why PR linked??

The issue needs to be linked. #8902

koppor · 2025-12-26T11:30:46Z

jabgui/src/main/java/org/jabref/gui/fieldeditors/DateEditorViewModel.java

    private static final Logger LOGGER = LoggerFactory.getLogger(DateEditorViewModel.class);
+
    private final DateTimeFormatter dateFormatter;
+    private static final TemporalAccessor RANGE_SENTINEL = LocalDate.of(1, 1, 1);


Comment missing - why this is used, which hese numbers chosen.

Siedlerchr · 2025-12-26T11:34:23Z

jabgui/src/main/java/org/jabref/gui/fieldeditors/DateEditorViewModel.java

+                    return dateFormatter.parse(text);
+                } catch (DateTimeException e) {
+                    LOGGER.error("Error while parsing date {}", text, e);
+                    return RANGE_SENTINEL;


Whenever the user has an invalid date., the 1.1.1970 is now returned which is wrong
Errors should stay errors. Invalid dates are invalid dates and not suddenly another

koppor · 2025-12-26T11:36:52Z

@Alex1034 You even did not add a test case for the original issue - WHY?

Then, the date is truncated into 2000.
If "Normalize date" is disabled (by skipping the step 3), the date is saved as 2000/2010.
A range of dates such as 2000/2010 should be saved as it is entered after "Normalize date."

koppor · 2025-12-26T11:37:04Z

/block

calixtus · 2025-12-26T12:54:23Z

PR

github-actions · 2025-12-26T12:54:57Z

This pull requests was closed without merging. You have been unassigned from the respective issue #8902. In case you closed the PR for yourself, you can re-open it. Please also check After submission of a pull request in CONTRIBUTING.md.

Alex1034 added 2 commits November 11, 2025 21:27

Fix

b6b8845

[PATCH] added support for date ranges for biblatex Date

43dfef2

Fixes JabRef#8902

github-actions bot added the first contrib label Nov 11, 2025

Alex1034 added 3 commits November 12, 2025 21:39

[style] Reformat Date and DateEditorViewModel to match JabRef guidelines

0d179de

[style] Reformat Date and DateEditorViewModel to match JabRef guidelines

83651d6

Merge branch 'main' into feature/date-range

ee996be

Siedlerchr reviewed Nov 15, 2025

View reviewed changes

Alex1034 added 5 commits November 15, 2025 19:48

[style] Reformat DateEditorViewModel to match JabRef guidelines

239a521

Refactor DateEditorViewModel

b7f9630

[style] Reformat DateEditorViewModel to match JabRef guidelines

d8682f2

[style] Reformat DateEditorViewModel to match JabRef guidelines

fce6390

[style] Reformat DateEditorViewModel to match JabRef guidelines

95955bb

calixtus changed the title ~~[PATCH] Added support for date ranges for BibLaTeX Date~~ Add support for date ranges for BibLaTeX Date Nov 15, 2025

Merge branch 'main' into feature/date-range

d2a2435

koppor requested changes Nov 20, 2025

View reviewed changes

github-actions bot added the status: changes-required Pull requests that are not yet complete label Nov 20, 2025

Add date range tests and changelog entry

6fc0ca6

github-actions bot removed the status: changes-required Pull requests that are not yet complete label Nov 20, 2025

Alex1034 added 5 commits November 20, 2025 21:16

Add date range tests and changelog entry

cbb7988

Repar changelog entry

505923a

Merge branch 'main' into feature/date-range

bd5d007

Add date range tests and changelog entry

d449518

Add date range tests and changelog entry

fc10103

koppor added the status: changes-required Pull requests that are not yet complete label Nov 21, 2025

Merge branch 'main' into feature/date-range

ecf0922

github-actions bot removed the status: changes-required Pull requests that are not yet complete label Nov 23, 2025

koppor requested changes Nov 23, 2025

View reviewed changes

github-actions bot added the status: changes-required Pull requests that are not yet complete label Nov 23, 2025

Repair

b6b98ca

Alex1034 added 2 commits November 23, 2025 21:33

Repair

7e081f7

Repair

5ea1f56

github-actions bot removed the status: changes-required Pull requests that are not yet complete label Nov 23, 2025

Alex1034 added 4 commits November 23, 2025 22:06

Repair

7549d96

Repair

bb8b928

Change

6a76953

Change

b7f9822

koppor added the status: changes-required Pull requests that are not yet complete label Nov 28, 2025

calixtus added the dev: code-quality Issues related to code or architecture decisions label Dec 12, 2025

calixtus reviewed Dec 12, 2025

View reviewed changes

jablib/src/test/java/org/jabref/model/entry/DateTest.java Outdated Show resolved Hide resolved

calixtus self-assigned this Dec 12, 2025

calixtus added the 📌 Pinned label Dec 12, 2025

calixtus and others added 2 commits December 20, 2025 16:04

Fixes

df93ccd

Merge branch 'main' into feature/date-range

dc4ea19

JabRef deleted a comment from jabref-machine Dec 22, 2025

koppor requested changes Dec 26, 2025

View reviewed changes

Siedlerchr reviewed Dec 26, 2025

View reviewed changes

calixtus closed this Dec 26, 2025

Uh oh!

Conversation

Alex1034 commented Nov 11, 2025 • edited by calixtus Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Steps to test

Additional details

Changelog

PR Checklist

Mandatory checks

Uh oh!

github-actions bot commented Nov 11, 2025

Hey @Alex1034!

Uh oh!

Siedlerchr Nov 15, 2025

Choose a reason for hiding this comment

Uh oh!

koppor left a comment

Choose a reason for hiding this comment

Uh oh!

koppor Nov 23, 2025

Choose a reason for hiding this comment

Uh oh!

koppor Nov 23, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Dec 1, 2025

Uh oh!

Uh oh!

calixtus commented Dec 22, 2025

Uh oh!

jabref-machine commented Dec 22, 2025

Uh oh!

koppor Dec 26, 2025

Choose a reason for hiding this comment

Uh oh!

koppor Dec 26, 2025

Choose a reason for hiding this comment

Uh oh!

Siedlerchr Dec 26, 2025

Choose a reason for hiding this comment

Uh oh!

koppor commented Dec 26, 2025

Uh oh!

koppor commented Dec 26, 2025

Uh oh!

calixtus commented Dec 26, 2025

Uh oh!

github-actions bot commented Dec 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Alex1034 commented Nov 11, 2025 •

edited by calixtus

Loading