Skip to content

Conversation

@Nakul-Shivaraj
Copy link
Contributor

@Nakul-Shivaraj Nakul-Shivaraj commented Nov 18, 2025

Closes #14346

Added final modifier and private constructor to ConflictRules utility class to prevent instantiation and subclassing, following Java best practices for utility classes containing only static methods.

@espertusnu - This addresses the utility class refactoring discussed on Gitter.

Steps to test

  1. Build the project: ./gradlew build
  2. Run existing tests: ./gradlew test
  3. Verify all tests pass - no functionality should be affected

Mandatory checks

koppor
koppor previously requested changes Nov 18, 2025
Copy link
Member

@koppor koppor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions github-actions bot added the status: changes-required Pull requests that are not yet complete label Nov 18, 2025
@github-actions github-actions bot removed the status: changes-required Pull requests that are not yet complete label Nov 19, 2025
@Siedlerchr Siedlerchr enabled auto-merge November 19, 2025 13:08
@Siedlerchr Siedlerchr added this pull request to the merge queue Nov 19, 2025
Merged via the queue into JabRef:main with commit 5be2cfd Nov 19, 2025
49 checks passed
merlinymy pushed a commit to merlinymy/jabref that referenced this pull request Nov 19, 2025
* Add final modifier and private constructor

* Update exception message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Code Refactoring

3 participants