print RPY in --test-connect#41
Closed
peter-mitrano-ar wants to merge 2 commits intoJakubAndrysek:masterfrom
Closed
print RPY in --test-connect#41peter-mitrano-ar wants to merge 2 commits intoJakubAndrysek:masterfrom
--test-connect#41peter-mitrano-ar wants to merge 2 commits intoJakubAndrysek:masterfrom
Conversation
added 2 commits
January 9, 2026 16:53
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR enhances the File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider labeling the printed values (e.g.,
x=... y=... z=... roll=...), so the--test-connectoutput is self-describing and easier to interpret when debugging. - If there is any possibility that
stateobjects might not have roll/pitch/yaw attributes (e.g., older drivers or different devices), it may be safer to guard access withhasattror a try/except to avoid runtime errors during--test-connect.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider labeling the printed values (e.g., `x=... y=... z=... roll=...`), so the `--test-connect` output is self-describing and easier to interpret when debugging.
- If there is any possibility that `state` objects might not have roll/pitch/yaw attributes (e.g., older drivers or different devices), it may be safer to guard access with `hasattr` or a try/except to avoid runtime errors during `--test-connect`.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Owner
|
Thanks for the PR, I have merged it together in a bigger update #44 https://github.com/JakubAndrysek/PySpaceMouse/releases/tag/2.0.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I mentioned this change in #40 , I hope it makes testing and debugging better :)
Summary by Sourcery
New Features: