Skip to content

Quaternion #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Quaternion #456

wants to merge 4 commits into from
+477 −6

Conversation

jnyfah
Copy link
Collaborator

@jnyfah jnyfah commented Jun 15, 2025 •
edited
Loading

Questions:

  1. will we be replacing std::sin and cos with our own implementation ?
  2. what is the rotation order? i assumed x -> y -> z
  3. in fromEulerAngles(double a, double b, double c) converting euler to quaternions i used double for the angles should i use T?

@jnyfah jnyfah marked this pull request as ready for review June 22, 2025 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeanPhilippeKernel JeanPhilippeKernel Awaiting requested review from JeanPhilippeKernel

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jnyfah