Cleanup and simplify transformers

Author: hsz

src/main/kotlin/org/jetbrains/intellij/platform/gradle/artifacts/transform/CollectorTransformer.kt

@@ -121,23 +121,7 @@ abstract class CollectorTransformer : TransformAction<CollectorTransformer.Param
                 .flatMap { it.listDirectoryEntries("*.jar") }
         }
 
-        internal fun register(
-            dependencies: DependencyHandler,
-            compileClasspathConfiguration: Configuration,
-            testCompileClasspathConfiguration: Configuration,
-            intellijPlatformClasspath: Configuration,
-            intellijPlatformTestClasspath: Configuration,
-            intellijPlatformConfiguration: Configuration,
-        ) {
-            Attributes.ArtifactType.values().forEach {
-                dependencies.artifactTypes.maybeCreate(it.toString())
-                    .attributes.attribute(Attributes.collected, false)
-            }
-
-            listOf(compileClasspathConfiguration, testCompileClasspathConfiguration, intellijPlatformClasspath, intellijPlatformTestClasspath).forEach {
-                it.attributes.attribute(Attributes.collected, true)
-            }
-
+        internal fun register(dependencies: DependencyHandler, intellijPlatformConfiguration: Configuration) {
             dependencies.registerTransform(CollectorTransformer::class) {
                 from
                     .attribute(Attributes.extracted, true)

src/main/kotlin/org/jetbrains/intellij/platform/gradle/artifacts/transform/ExtractorTransformer.kt

@@ -2,7 +2,6 @@
 
 package org.jetbrains.intellij.platform.gradle.artifacts.transform
 
-import org.gradle.api.artifacts.Configuration
 import org.gradle.api.artifacts.dsl.DependencyHandler
 import org.gradle.api.artifacts.transform.InputArtifact
 import org.gradle.api.artifacts.transform.TransformAction
@@ -160,22 +159,7 @@ abstract class ExtractorTransformer @Inject constructor(
     }
 
     companion object {
-        internal fun register(
-            dependencies: DependencyHandler,
-            compileClasspathConfiguration: Configuration,
-            testCompileClasspathConfiguration: Configuration,
-            intellijPlatformClasspath: Configuration,
-            intellijPlatformTestClasspath: Configuration,
-        ) {
-            Attributes.ArtifactType.Archives.forEach {
-                dependencies.artifactTypes.maybeCreate(it.toString())
-                    .attributes.attribute(Attributes.extracted, false)
-            }
-
-            listOf(compileClasspathConfiguration, testCompileClasspathConfiguration, intellijPlatformClasspath, intellijPlatformTestClasspath).forEach {
-                it.attributes.attribute(Attributes.extracted, true)
-            }
-
+        internal fun register(dependencies: DependencyHandler) {
             dependencies.registerTransform(ExtractorTransformer::class) {
                 from.attribute(Attributes.extracted, false)
                 to.attribute(Attributes.extracted, true)

src/main/kotlin/org/jetbrains/intellij/platform/gradle/plugins/project/IntelliJPlatformBasePlugin.kt

@@ -21,19 +21,14 @@ import org.jetbrains.intellij.platform.gradle.artifacts.transform.CollectorTrans
 import org.jetbrains.intellij.platform.gradle.artifacts.transform.ExtractorTransformer
 import org.jetbrains.intellij.platform.gradle.artifacts.transform.LocalIvyArtifactPathComponentMetadataRule
 import org.jetbrains.intellij.platform.gradle.artifacts.transform.LocalPluginsNormalizationTransformers
-import org.jetbrains.intellij.platform.gradle.extensions.IntelliJPlatformDependenciesExtension
-import org.jetbrains.intellij.platform.gradle.extensions.IntelliJPlatformDependenciesHelper
-import org.jetbrains.intellij.platform.gradle.extensions.IntelliJPlatformExtension
+import org.jetbrains.intellij.platform.gradle.extensions.*
 import org.jetbrains.intellij.platform.gradle.extensions.IntelliJPlatformExtension.*
 import org.jetbrains.intellij.platform.gradle.extensions.IntelliJPlatformExtension.PluginConfiguration.*
-import org.jetbrains.intellij.platform.gradle.extensions.IntelliJPlatformRepositoriesExtension
-import org.jetbrains.intellij.platform.gradle.extensions.localPlatformArtifactsPath
 import org.jetbrains.intellij.platform.gradle.get
 import org.jetbrains.intellij.platform.gradle.plugins.checkGradleVersion
 import org.jetbrains.intellij.platform.gradle.tasks.*
 import org.jetbrains.intellij.platform.gradle.tasks.aware.*
 import org.jetbrains.intellij.platform.gradle.utils.*
-import org.jetbrains.intellij.platform.gradle.utils.create
 import kotlin.io.path.absolute
 import kotlin.io.path.invariantSeparatorsPathString
 
@@ -136,7 +131,7 @@ abstract class IntelliJPlatformBasePlugin : Plugin<Project> {
 
                         log.info("$ruleName has been registered.")
                     }
-                }  else {
+                } else {
                     log.info("$ruleName can not be registered because '${rulesMode}' mode is used in settings.")
                 }
             }
@@ -345,24 +340,28 @@ abstract class IntelliJPlatformBasePlugin : Plugin<Project> {
                 attribute(Attributes.extracted)
             }
 
-            ExtractorTransformer.register(
-                dependencies = this,
-                compileClasspathConfiguration = project.configurations[Configurations.External.COMPILE_CLASSPATH],
-                testCompileClasspathConfiguration = project.configurations[Configurations.External.TEST_COMPILE_CLASSPATH],
-                intellijPlatformClasspath = project.configurations[Configurations.INTELLIJ_PLATFORM_CLASSPATH],
-                intellijPlatformTestClasspath = project.configurations[Configurations.INTELLIJ_PLATFORM_TEST_CLASSPATH],
-            )
-            CollectorTransformer.register(
-                dependencies = this,
-                compileClasspathConfiguration = project.configurations[Configurations.External.COMPILE_CLASSPATH],
-                testCompileClasspathConfiguration = project.configurations[Configurations.External.TEST_COMPILE_CLASSPATH],
-                intellijPlatformClasspath = project.configurations[Configurations.INTELLIJ_PLATFORM_CLASSPATH],
-                intellijPlatformTestClasspath = project.configurations[Configurations.INTELLIJ_PLATFORM_TEST_CLASSPATH],
-                intellijPlatformConfiguration = project.configurations[Configurations.INTELLIJ_PLATFORM_DEPENDENCY],
-            )
-            LocalPluginsNormalizationTransformers.register(
-                dependencies = this
-            )
+            Attributes.ArtifactType.Archives.forEach {
+                artifactTypes.maybeCreate(it.toString())
+                    .attributes
+                    .attribute(Attributes.extracted, false)
+                    .attribute(Attributes.collected, false)
+            }
+
+            listOf(
+                project.configurations[Configurations.External.COMPILE_CLASSPATH],
+                project.configurations[Configurations.External.RUNTIME_CLASSPATH],
+                project.configurations[Configurations.External.TEST_COMPILE_CLASSPATH],
+                project.configurations[Configurations.INTELLIJ_PLATFORM_CLASSPATH],
+                project.configurations[Configurations.INTELLIJ_PLATFORM_TEST_CLASSPATH],
+            ).forEach {
+                it.attributes
+                    .attribute(Attributes.extracted, true)
+                    .attribute(Attributes.collected, true)
+            }
+
+            ExtractorTransformer.register(this)
+            CollectorTransformer.register(this, project.configurations[Configurations.INTELLIJ_PLATFORM_DEPENDENCY])
+            LocalPluginsNormalizationTransformers.register(this)
 
             project.pluginManager.withPlugin(Plugins.External.JAVA_TEST_FIXTURES) {
                 project.configurations[Configurations.External.TEST_FIXTURES_COMPILE_CLASSPATH]