origin/radio_button_vika #1412
Open
origin/radio_button_vika #1412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced old radio button images with updated versions, adding light and dark mode variants for clarity and consistency. Older assets were moved to a dedicated "old" folder for archival purposes. This improves structure and supports a more modern visual design.
Updated phrasing to improve clarity and consistency, emphasizing when to use checkboxes for two opposing choices. No functional or structural changes were made.
eldar-jetbrains
approved these changes
Jan 7, 2025
| @@ -89,19 +107,22 @@ Use the imperative form of verbs. | |||
|
|
|||
| Do not use negation in labels as it complicates understanding. | |||
There was a problem hiding this comment.
- Possibly add examples for each rule here with correct incorrect usages to help people better understand the rules
- Add bullets to the bullet list
There was a problem hiding this comment.
This shouldn't be a bullet list according to how we write articles now. See how the same section is structured in the Button article
There was a problem hiding this comment.
What do you think if I add all the wrong things in one image? I think it’s quite possible.
topics/ui/controls/radio_button.md
Outdated
| <td><img src="07_How_to_use.png" alt="An example of a label spanning two lines." width="378"/></td> | ||
| <td><p>If a label is long, split it into two lines. Avoid labels that take more than two lines. See recommendations on writing concise labels below.</p></td> | ||
| </tr> | ||
| </table> | ||
|
|
||
| To implement this, use HTML formatting: |
There was a problem hiding this comment.
Make a collapsible "Implementation" chapter
|
|
||
| Make labels short and intelligible — see [Writing short and clear text](writing_short.md). | ||
|
|
||
| ### Group label | ||
|
|
||
| {width=267} | ||
| {width=706} | ||
|
|
||
| Always start a radio button group with a group label. It explains what the options are for. | ||
|
|
There was a problem hiding this comment.
I would replace the content in Sizes and placement chapter into this one: https://plugins.jetbrains.com/docs/intellij/layout.html#checkboxes-and-radio-buttons as "Follow the layout of /checkboxes and radio-buttons/(anchor-link)
OlyaB
requested changes
Jan 9, 2025
| @@ -89,19 +107,22 @@ Use the imperative form of verbs. | |||
|
|
|||
| Do not use negation in labels as it complicates understanding. | |||
There was a problem hiding this comment.
This shouldn't be a bullet list according to how we write articles now. See how the same section is structured in the Button article
Refined documentation for radio button usage, including adjustments to labels, option grouping, and alternative UI recommendations. Updated associated images for consistency. Modified Kotlin and Gradle configurations in project settings.
Updated the recommended number of options for radio buttons and cleaned up examples in the dropdown section. Refactored implementation code examples using collapsible chapters for better readability in rendered documentation.
Removed redundant image table and streamlined text for clarity. Added updated images to improve guidance on correct and incorrect labeling practices. Ensured consistent formatting across the documentation.
Added clear formatting tags to emphasize correct and incorrect examples in the documentation. This enhances readability and helps users quickly differentiate between correct and incorrect usage.
Refined the "How to use" images to align with updated UI elements. Ensures consistency and clarity for both light and dark theme presentations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.