K/N Pass cacheable zipFileSystemAccessor to missing sections KT-81670 #5520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please write a good commit message according to our rules: https://github.com/JetBrains/kotlin/blob/master/docs/code_authoring_and_core_review.md#commit-messages-and-yt-tickets The YouTrack ticket number should be specified in the commit message. |
alfonsocv12
force-pushed
the
fix/passCacheableZipAccessor
branch
from
21c23ae to
91e5239
Compare
…to missing sections While profiling a regression with -Xklib-zip-file-accessor-cache-limit flag set, createKonanLibary and createKonanLibraryComponnets appear as hot and using ZipFileSystemInPlaceAccessor (Not cacheable). KT-81670
alfonsocv12
force-pushed
the
fix/passCacheableZipAccessor
branch
from
91e5239 to
2fe04a0
Compare
|
Thanks for the documentation, just updated the commit, what do you think now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internally at google we have a patch for KotlinLibraryLayoutImpl.kt that changes the else value of klibZipAccessor to ZipFileSystemCacheableAccessor with 100 limit, after updating to 2.3.0-dev-7988 we removed the patch since it was no longer required. This resulted in a regression of ~24%.
This doesn't fix all the issues (because theres a lot of different usages of KotlinLibraryLayoutImpl) but it fixes our internal regression.