Skip to content
This repository was archived by the owner on Mar 26, 2024. It is now read-only.

Perf optimization #18

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Perf optimization #18

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
e60b161
perf improvement
wpc009 Mar 19, 2021
a5d580e
Merge branch 'master' of https://github.com/JetBrains/projector-client
wpc009 Mar 25, 2021
4872a4e
Performance tuning
wpc009 Apr 1, 2021
252148f
revert wire protocol version assertion
wpc009 Apr 1, 2021
01ec80e
revert codestyle config
wpc009 Apr 1, 2021
bde7a74
revert unnecessary changes
wpc009 Apr 1, 2021
8f35f4b
clean code
wpc009 Apr 1, 2021
b72134d
passing checks
wpc009 Apr 1, 2021
0dba75d
fix tests
wpc009 Apr 1, 2021
921bd1e
Adding extra v8 flags
wpc009 Apr 1, 2021
cd6c602
Adding usefull Electron Menu items
wpc009 Apr 1, 2021
cbff8dd
[Optimization]
wpc009 Apr 8, 2021
aacd44d
Merge branch 'master' into perf-optimization
wpc009 Apr 8, 2021
b9881ce
Merge
wpc009 Apr 8, 2021
5750e47
Merge branch 'master' of https://github.com/JetBrains/projector-clien…
wpc009 Apr 8, 2021
004fda9
revert ClientState changes
wpc009 Apr 8, 2021
9541c50
fix merge typo
wpc009 Apr 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
# SOFTWARE.
#
bootstrapVersion=4.5.2
coroutinesVersion=1.4.1
coroutinesVersion=1.4.3
dnsjavaVersion=2.1.9
electronVersion=^10.1.2
electronPackagerVersion=^15.1.0
Expand All @@ -31,10 +31,10 @@ inlineStylePrefixerVersion=~6.0.0
javassistVersion=3.27.0-GA
javaWebSocketVersion=1.5.1
jqueryVersion=3.5.1
kotlinVersion=1.4.20
kotlinExtensionsVersion=1.0.1-pre.129-kotlin-1.4.10
kotlinReactVersion=16.14.0-pre.125-kotlin-1.4.10
kotlinStyledComponentsVersion=5.2.0-pre.129-kotlin-1.4.10
kotlinVersion=1.4.30
kotlinExtensionsVersion=1.0.1-pre.146-kotlin-1.4.30
kotlinReactVersion= 17.0.1-pre.146-kotlin-1.4.30
kotlinStyledComponentsVersion=5.2.1-pre.146-kotlin-1.4.30
Copy link
Member

@SerVB SerVB Apr 8, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will update Kotlin and dependencies to 1.4.30 on the next week, it seems there are some performance improvements.

By the way, there is a relatively new mode of compilation called IR. It can give more performant code too. I will try it later, but if you have some time, you can try it yourself. Just add (IR) to build.gradle(.kts) files of JS and multiplatform modules like this:

kotlin {
    js(IR) {  // <-- here it was just "js {"
      //...
    }
}

At least many Kotlin.isType are replaced with JS instanceof in IR.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will try that.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will update Kotlin and dependencies to 1.4.30 on the next week, it seems there are some performance improvements.

By the way, there is a relatively new mode of compilation called IR. It can give more performant code too. I will try it later, but if you have some time, you can try it yourself. Just add (IR) to build.gradle(.kts) files of JS and multiplatform modules like this:

kotlin {
    js(IR) {  // <-- here it was just "js {"
      //...
    }
}

At least many Kotlin.isType are replaced with JS instanceof in IR.

just add IR in projector-client-web will cause :

dceTask configuration is useless with IR compiler. Use @JsExport on declarations instead.

FAILURE: Build failed with an exception.

  • What went wrong:
    Task 'browserProductionWebpack' not found in project ':projector-client-web'.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

projector-client-web is already some time with IR enabled and that problem solved:

projector-client/projector-client-web/build.gradle.kts

Line 63 in 2811e60

js(IR) {

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

projector-client-web is already some time with IR enabled and that problem solved:

projector-client/projector-client-web/build.gradle.kts

Line 63 in 2811e60

js(IR) {

thanks ,I merger the pr to my 1.6.0 version and it shows ok . I found you have released it to 1.7.0 , I will use the latest version after PRJ-857 fix

ktorVersion=1.4.1
openVersion=^7.2.1
radiumVersion=0.26.1
Expand Down
Loading