add internal option for suppressing errors in render-pipelines

Author: krasnotsvetov

resharper/resharper-unity/src/Application/UI/Options/VisualStudio/ReSharperOptionsPage.cs

@@ -73,8 +73,11 @@ public ReSharperOptionsPage(Lifetime lifetime, OptionsPageContext pageContext,
             {
                 AddHeader("Internal");
 
+                AddBoolOption((UnitySettings s) => s.SuppressShaderErrorHighlightingInRenderPipelinePackages, 
+                    "Suppress resolve errors in render-pipeline packages");
+                
                 AddBoolOption((UnitySettings s) => s.EnableCgErrorHighlighting,
-                    "Parse Cg files for syntax errors (requires internal mode, and re-opening solution)");
+                    "[Deprecated] Parse GLSL files for syntax errors (requires internal mode, and re-opening solution)");
             }
         }
     }

resharper/resharper-unity/src/HlslSupport/Daemon/UnityHlslAllErrorsPredicate.cs

@@ -1,6 +1,9 @@
 using JetBrains.Application.Settings;
 using JetBrains.Collections.Viewable;
+using JetBrains.DataFlow;
+using JetBrains.Lifetimes;
 using JetBrains.ProjectModel;
+using JetBrains.ProjectModel.DataContext;
 using JetBrains.ReSharper.Plugins.Unity.ProjectModel;
 using JetBrains.ReSharper.Plugins.Unity.Settings;
 using JetBrains.ReSharper.Psi.Cpp.Tree;
@@ -10,18 +13,30 @@ namespace JetBrains.ReSharper.Plugins.Unity.HlslSupport.Daemon
     [SolutionComponent]
     public class UnityHlslAllErrorsPredicate : IHlslUnresolvedUnqualifiedNamesErrorsPredicate {
         private readonly UnitySolutionTracker myUnitySolutionTracker;
+        private readonly IProperty<bool> mySuppressShaderErrors;
+        private readonly IProperty<bool> mySuppressShaderErrorsInRenderPipeline;
 
-        public UnityHlslAllErrorsPredicate(UnitySolutionTracker unitySolutionTracker)
+        public UnityHlslAllErrorsPredicate(Lifetime lifetime, ISolution solution, UnitySolutionTracker unitySolutionTracker, ISettingsStore settingsStore)
         {
             myUnitySolutionTracker = unitySolutionTracker;
+            mySuppressShaderErrors = settingsStore.BindToContextLive(lifetime, ContextRange.Smart(solution.ToDataContext()))
+                .GetValueProperty(lifetime, (UnitySettings key) => key.SuppressShaderErrorHighlighting);
+            mySuppressShaderErrorsInRenderPipeline = settingsStore.BindToContextLive(lifetime, ContextRange.Smart(solution.ToDataContext()))
+                .GetValueProperty(lifetime, (UnitySettings key) => key.SuppressShaderErrorHighlightingInRenderPipelinePackages);
         }
 
         public bool SuppressUnresolvedErrors(CppFile cppFile, IContextBoundSettingsStore settingsStore)
         {
             if (!myUnitySolutionTracker.IsUnityProject.HasTrueValue())
                 return false;
 
-            return settingsStore.GetValue((UnitySettings k) => k.SuppressShaderErrorHighlighting);
+            if (mySuppressShaderErrorsInRenderPipeline.Value)
+            {
+                var location = cppFile.File;
+                if (location.FullPath.Contains(".render-pipelines"))
+                    return true;
+            }
+            return mySuppressShaderErrors.Value;
         }
 
         public bool SuppressUnresolvedUnqualifiedErrors(CppFile cppFile, IContextBoundSettingsStore settingsStore)

resharper/resharper-unity/src/Rider/UnityOptionsPage.cs

@@ -120,8 +120,11 @@ public UnityOptionsPage(Lifetime lifetime, OptionsPageContext pageContext,
             {
                 AddHeader("Internal");
 
+                AddBoolOption((UnitySettings s) => s.SuppressShaderErrorHighlightingInRenderPipelinePackages, 
+                    "Suppress resolve errors in render-pipeline packages");
+                
                 AddBoolOption((UnitySettings s) => s.EnableCgErrorHighlighting,
-                    "Parse Cg files for syntax errors (requires internal mode, and re-opening solution)");
+                    "[Deprecated] Parse GLSL files for syntax errors (requires internal mode, and re-opening solution)");
             }
         }
 

resharper/resharper-unity/src/Settings/UnitySettings.cs

@@ -35,9 +35,12 @@ public class UnitySettings
         [SettingsEntry(false, "Enables syntax error highlighting of CG blocks in ShaderLab files.")]
         public bool EnableCgErrorHighlighting;
 
-        [SettingsEntry(false, "Suppress resolve errors of unqualified names in HLSL.")]
+        [SettingsEntry(false, "Suppress resolve errors in HLSL.")]
         public bool SuppressShaderErrorHighlighting;
 
+        [SettingsEntry(false, "Suppress resolve errors in render-pipeline package in HLSL.")]
+        public bool SuppressShaderErrorHighlightingInRenderPipelinePackages;
+        
         [SettingsEntry(GutterIconMode.CodeInsightDisabled, "Unity highlighter scheme for editor.")]
         public GutterIconMode GutterIconMode;