-
Notifications
You must be signed in to change notification settings - Fork 275
fix: Fix DeprecationWarning: Module.issuer: Use new ModuleGraph API #423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
f6a598b
to
72054fa
Compare
checks failed , @MalikBen |
Looks like test for const isWebpackGreaterThan5 = version[0] >= 5; to const isWebpackGreaterThan5 = version && version[0] >= 5; |
ping @MalikBen |
1 similar comment
ping @MalikBen |
@pbn04001 can I open a new PR to fix this warning? |
@b-e-r-t-o Yes, you can |
Hi, I'm sorry I was receiving all the e-mails in my spam box, is this issue fixed ? Should I close it ? |
For what it's worth, I'm no longer seeing this issue. Probably best to wait until a few others weight in before closing it, though, IMHO 🙂 |
Wait, nvm, I was testing with an outdated version of |
What kind of change does this PR introduce? (bugfix, feature, docs update, improvement)
Removes warning by using ModuleGraph in case of webpack version >= 5
What is the current behavior? (You can also link to an open issue here)
webpack5 build throws a DeprecationWarning
[DEP_WEBPACK_MODULE_ISSUER] DeprecationWarning: Module.issuer: Use new ModuleGraph API
See #418
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change?
Please check if the PR fulfills contributing guidelines